Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly replace cache in namespace isolation mode #3023

Merged
merged 1 commit into from
Jan 24, 2020

Conversation

alexmt
Copy link
Collaborator

@alexmt alexmt commented Jan 23, 2020

Closes #3008

@alexmt alexmt requested a review from jessesuen January 23, 2020 23:55
@codecov
Copy link

codecov bot commented Jan 24, 2020

Codecov Report

Merging #3023 into master will increase coverage by 0.01%.
The diff coverage is 76.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3023      +/-   ##
==========================================
+ Coverage   38.23%   38.24%   +0.01%     
==========================================
  Files         168      168              
  Lines       18142    18142              
  Branches      237      237              
==========================================
+ Hits         6936     6938       +2     
+ Misses      10340    10339       -1     
+ Partials      866      865       -1
Impacted Files Coverage Δ
controller/cache/cluster.go 64.2% <76.47%> (+0.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7cad4a...8af18ba. Read the comment docs.

@alexmt alexmt merged commit 32d5a05 into argoproj:master Jan 24, 2020
@alexmt alexmt deleted the 3008-multi-network-caching branch December 15, 2021 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ArgoCD 1.4 Resources synchronized but still in OutOfSynch/Missing
2 participants