Issue #482 - Support IAM Authentication for managing external K8s clusters #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexmt
force-pushed
the
482-iam-auth
branch
from
b9a9815
to
a8715b9
Compare
jessesuen
requested changes
Sep 13, 2018
cmd/argocd/commands/cluster.go
Outdated
| upsert bool | ||
| inCluster bool | ||
| upsert bool | ||
| awsAuth bool |
There was a problem hiding this comment.
I think awsAuth bool is redundant. We can infer AWS auth by the presence of awsClusterName.
There was a problem hiding this comment.
Sound good to me. Removed awsAuth
| ExecProvider: &api.ExecConfig{ | ||
| APIVersion: "client.authentication.k8s.io/v1alpha1", | ||
| Command: "aws-iam-authenticator", | ||
| Args: []string{"token", "-i", c.Config.AWSAuthConfig.ClusterName}, |
There was a problem hiding this comment.
You are forgetting to pass roleARN if it is non-empty.
alexmt
force-pushed
the
482-iam-auth
branch
from
a8715b9
to
db8aeba
Compare
|
@jessesuen PTAL |
jessesuen
approved these changes
Sep 13, 2018
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #482