Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): Improved applications list filters #6091

Merged
merged 27 commits into from
Jul 1, 2021

Conversation

rbreeze
Copy link
Member

@rbreeze rbreeze commented Apr 22, 2021

Updated applications list filters have been completely refactored to be more reliable and easier to maintain. They also have a new coat of paint and some usability enhancements:

Screen Shot 2021-04-22 at 1 13 34 PM

Filters have been separated into sections to allow for clearing one set of filters without clearing every section. Additionally, counts do not change when filter is selected.

For text-based filters, filters you've added recently stick around after you've unchecked them (until page refresh):

Screen Shot 2021-04-22 at 12 53 34 PM

Improved narrow screen view:

Screen Shot 2021-04-22 at 3 10 17 PM

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

Signed-off-by: Remington Breeze <remington@breeze.software>
…ilters

Signed-off-by: Remington Breeze <remington@breeze.software>
Signed-off-by: Remington Breeze <remington@breeze.software>
Signed-off-by: Remington Breeze <remington@breeze.software>
Signed-off-by: Remington Breeze <remington@breeze.software>
Signed-off-by: Remington Breeze <remington@breeze.software>
Signed-off-by: Remington Breeze <remington@breeze.software>
Signed-off-by: Remington Breeze <remington@breeze.software>
Signed-off-by: Remington Breeze <remington@breeze.software>
@rbreeze rbreeze requested a review from alexmt April 22, 2021 22:11
@codecov
Copy link

codecov bot commented Apr 22, 2021

Codecov Report

Merging #6091 (e3bc1d4) into master (5bd2f61) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6091      +/-   ##
==========================================
+ Coverage   41.25%   41.30%   +0.04%     
==========================================
  Files         156      156              
  Lines       20672    20688      +16     
==========================================
+ Hits         8529     8545      +16     
- Misses      10935    10936       +1     
+ Partials     1208     1207       -1     
Impacted Files Coverage Δ
util/argo/argo.go 61.75% <0.00%> (ø)
pkg/apis/application/v1alpha1/types.go 57.89% <0.00%> (ø)
controller/appcontroller.go 53.36% <0.00%> (+0.09%) ⬆️
util/settings/settings.go 47.27% <0.00%> (+0.27%) ⬆️
server/application/logs.go 85.71% <0.00%> (+1.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bd2f61...e3bc1d4. Read the comment docs.

Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New filters look awesome! Added several comments.

Regarding useData. As I understand you want to replace DataLoader with useData eventually, correct? There is another important feature that is "missing": ability to "reload" when "input" changes. E.g.

useData(params.get('search'), (filter) => services.projects.list('items.metadata.name'))

Do you think it will be possible to support it in useData?

Signed-off-by: Remington Breeze <remington@breeze.software>
Signed-off-by: Remington Breeze <remington@breeze.software>
@rbreeze rbreeze requested a review from alexmt May 4, 2021 23:14
Signed-off-by: Remington Breeze <remington@breeze.software>
Signed-off-by: Remington Breeze <remington@breeze.software>
Signed-off-by: Remington Breeze <remington@breeze.software>
Signed-off-by: Remington Breeze <remington@breeze.software>
Signed-off-by: Remington Breeze <remington@breeze.software>
ui/package.json Outdated Show resolved Hide resolved
Signed-off-by: Remington Breeze <remington@breeze.software>
@rbreeze rbreeze requested a review from alexmt June 22, 2021 21:13
Signed-off-by: Remington Breeze <remington@breeze.software>
Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like something went wrong after merging laster code. UI looks strange:

Screen Shot 2021-06-22 at 5 06 38 PM

ui/src/app/applications/components/filter/filter.tsx Outdated Show resolved Hide resolved
ui/src/app/applications/components/utils.tsx Outdated Show resolved Hide resolved
Signed-off-by: Remington Breeze <remington@breeze.software>
@rbreeze rbreeze requested a review from alexmt June 23, 2021 19:06
Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix more nitpicks with autocomplete please:

  • Autocomplete dropdown is too small. In a previous implementation, dropdown max height is much bigger (360px).

image

  • Previous autocomplete expands to the top or bottom based on amount of page space available. E.g. if input is too close to page bottom then dropdown expands to the top:

image

  • We lost option highlighting on mouse hover:

image

  • When user selects option the autocomplete input should be cleared

Signed-off-by: Remington Breeze <remington@breeze.software>
@rbreeze rbreeze requested a review from alexmt June 29, 2021 19:46
Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for resolving my comments! Hopefully few last nitpicks

Signed-off-by: Remington Breeze <remington@breeze.software>
@rbreeze rbreeze requested a review from alexmt June 30, 2021 21:43
Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM

Please remove console.log before merging since linter does not like it.

Signed-off-by: Remington Breeze <remington@breeze.software>
@rbreeze rbreeze merged commit 2a41018 into argoproj:master Jul 1, 2021
@rbreeze rbreeze deleted the list-enhancements branch July 1, 2021 00:29
@alexmt alexmt added the needs-verification PR requires pre-release verification label Jul 28, 2021
@rbreeze rbreeze removed the needs-verification PR requires pre-release verification label Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants