Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new sync option to fail if finds shared resources #7444

Merged
merged 2 commits into from
Oct 20, 2021

Conversation

leoluz
Copy link
Collaborator

@leoluz leoluz commented Oct 14, 2021

Signed-off-by: Leonardo Luz Almeida leonardo_almeida@intuit.com

Fixes #7156

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
@codecov
Copy link

codecov bot commented Oct 14, 2021

Codecov Report

Merging #7444 (b6c1ef8) into master (d7d8fe3) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7444      +/-   ##
==========================================
+ Coverage   41.32%   41.39%   +0.07%     
==========================================
  Files         161      161              
  Lines       21590    21615      +25     
==========================================
+ Hits         8921     8947      +26     
+ Misses      11408    11406       -2     
- Partials     1261     1262       +1     
Impacted Files Coverage Δ
controller/sync.go 65.13% <100.00%> (+2.19%) ⬆️
server/cluster/cluster.go 22.51% <0.00%> (-0.36%) ⬇️
reposerver/repository/repository.go 60.64% <0.00%> (-0.31%) ⬇️
controller/appcontroller.go 53.14% <0.00%> (-0.17%) ⬇️
cmd/argocd/commands/login.go 2.29% <0.00%> (-0.03%) ⬇️
cmd/argocd/commands/relogin.go 0.00% <0.00%> (ø)
pkg/apis/application/v1alpha1/types.go 57.51% <0.00%> (ø)
util/settings/settings.go 47.02% <0.00%> (+0.25%) ⬆️
pkg/apis/application/v1alpha1/app_project_types.go 52.10% <0.00%> (+0.50%) ⬆️
controller/metrics/clustercollector.go 54.16% <0.00%> (+54.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7d8fe3...b6c1ef8. Read the comment docs.

Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you @leoluz ! I agree with the new option name.

@alexmt
Copy link
Collaborator

alexmt commented Oct 19, 2021

Saw your comment here: #7156 (comment)

I agree that PR should include docs. Will merge once docs are added

@jannfis jannfis added hacktoberfest hacktoberfest-accepted Accepted Hacktoberfest contribution labels Oct 20, 2021
Signed-off-by: Leonardo Luz Almeida <leoluz@users.noreply.github.com>
@leoluz
Copy link
Collaborator Author

leoluz commented Oct 20, 2021

@alexmt Thank you Alex. Docs added.

Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest hacktoberfest-accepted Accepted Hacktoberfest contribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fail application sync if it creates resource already managed by another Application CRD
3 participants