-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add new sync option to fail if finds shared resources #7444
Conversation
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
Codecov Report
@@ Coverage Diff @@
## master #7444 +/- ##
==========================================
+ Coverage 41.32% 41.39% +0.07%
==========================================
Files 161 161
Lines 21590 21615 +25
==========================================
+ Hits 8921 8947 +26
+ Misses 11408 11406 -2
- Partials 1261 1262 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you @leoluz ! I agree with the new option name.
Saw your comment here: #7156 (comment) I agree that PR should include docs. Will merge once docs are added |
Signed-off-by: Leonardo Luz Almeida <leoluz@users.noreply.github.com>
466fb03
to
b6c1ef8
Compare
@alexmt Thank you Alex. Docs added. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Leonardo Luz Almeida leonardo_almeida@intuit.com
Fixes #7156
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist: