-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Allow all resources to add external links #7923
Conversation
f5eafd9
to
e0a4399
Compare
FWIW I've cherry-picked this change on top of the v2.1.7 we run locally, and it seems to work. Happy to open a second PR to copy the change to the release-2.2 branch or whatever is needed to get it in the next release... |
Signed-off-by: Tristan Keen <tristan.keen@gmail.com>
e0a4399
to
540b2cf
Compare
I've rebased & added another test - any chance of review or at least letting CI run @alexmt ? (Sorry don't know who else to ask - no response on CNCF slack...) |
Codecov Report
@@ Coverage Diff @@
## master #7923 +/- ##
==========================================
- Coverage 41.53% 41.52% -0.01%
==========================================
Files 174 174
Lines 22705 22700 -5
==========================================
- Hits 9430 9427 -3
+ Misses 11921 11918 -3
- Partials 1354 1355 +1
Continue to review full report at Codecov.
|
Thanks for your PR and your patience, @tyrken - I'll take a closer look at this one ASAP. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as well
Improves the phase 1 implementation of #3487 to allow adding links via annotations to all resource types, including ingresses/pods/services that previously skipped looking for annotations.