Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Log out the resource triggering reconciliation #8192

Merged
merged 2 commits into from
Jan 18, 2022

Conversation

jannfis
Copy link
Member

@jannfis jannfis commented Jan 16, 2022

In case of a controller requested app refresh, it might be good to know which resource has triggered the controller to initiate the reconciliation.

This PR adds debugging information for that.

Related to #8100

Signed-off-by: jannfis jann@mistrust.net

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

Signed-off-by: jannfis <jann@mistrust.net>
Signed-off-by: jannfis <jann@mistrust.net>
@codecov
Copy link

codecov bot commented Jan 16, 2022

Codecov Report

Merging #8192 (d5a0efe) into master (41fc70d) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8192      +/-   ##
==========================================
- Coverage   41.62%   41.61%   -0.02%     
==========================================
  Files         174      174              
  Lines       22715    22722       +7     
==========================================
  Hits         9456     9456              
- Misses      11905    11911       +6     
- Partials     1354     1355       +1     
Impacted Files Coverage Δ
controller/appcontroller.go 51.82% <0.00%> (-0.36%) ⬇️
util/settings/settings.go 47.01% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41fc70d...d5a0efe. Read the comment docs.

@jannfis jannfis requested a review from alexmt January 16, 2022 15:59
Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jannfis jannfis merged commit 0104110 into argoproj:master Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants