-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Horizontal Scrolling doesn't appear until page end (#8298) #8462
fix: Horizontal Scrolling doesn't appear until page end (#8298) #8462
Conversation
Signed-off-by: Keith Chong <kykchong@redhat.com>
Codecov Report
@@ Coverage Diff @@
## master #8462 +/- ##
=======================================
Coverage 42.10% 42.10%
=======================================
Files 177 177
Lines 22912 22912
=======================================
Hits 9647 9647
Misses 11889 11889
Partials 1376 1376 Continue to review full report at Codecov.
|
hey Keith! Just tried this out and this is what I saw on my end, I'm not sure if this actually fixes the problem or not? I'm on chrome btw, I'm not sure if you were on a different browser (This first part is checked out to master branch, the second is switching to your branch) horizontalScroll.mp4 |
Hey @reginapizza , it looks like you are saying that the vertical scrollbar height is no longer reaching to the very top of the page. The height of the viewable area is limited to that 'scrollable' viewable tree section. So the vertical scrollbar is visible there and no longer includes the status panel. Another way to look at it is, the status panel is not scrolled since it is permanent, and only the tree is scrolled. Note, this PR does not change the width of the viewable scrollable. The horizontal scrollbar 'length' is still an issue but once the filter is moved to the side panel/margin (the PR that @rbreeze always wanted to get merged), then we won't have that issue. |
@keithchong I see, I'm okay with this solution then! LGTM 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @keithchong . Tried locally as well - looks great.
… (argoproj#8462) Signed-off-by: Keith Chong <kykchong@redhat.com> Signed-off-by: wojtekidd <wojtek.cichon@protonmail.com>
Signed-off-by: Keith Chong kykchong@redhat.com
Fixes #8298
Limit the height of the parent to only the viewable area, but allow the inner contents to scroll.
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist: