Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Horizontal Scrolling doesn't appear until page end (#8298) #8462

Merged

Conversation

keithchong
Copy link
Contributor

@keithchong keithchong commented Feb 10, 2022

Signed-off-by: Keith Chong kykchong@redhat.com

Fixes #8298

Limit the height of the parent to only the viewable area, but allow the inner contents to scroll.

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

Signed-off-by: Keith Chong <kykchong@redhat.com>
@codecov
Copy link

codecov bot commented Feb 10, 2022

Codecov Report

Merging #8462 (a906a13) into master (52b13c2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8462   +/-   ##
=======================================
  Coverage   42.10%   42.10%           
=======================================
  Files         177      177           
  Lines       22912    22912           
=======================================
  Hits         9647     9647           
  Misses      11889    11889           
  Partials     1376     1376           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52b13c2...a906a13. Read the comment docs.

@reginapizza
Copy link
Contributor

reginapizza commented Feb 11, 2022

hey Keith! Just tried this out and this is what I saw on my end, I'm not sure if this actually fixes the problem or not? I'm on chrome btw, I'm not sure if you were on a different browser

(This first part is checked out to master branch, the second is switching to your branch)

horizontalScroll.mp4

@keithchong
Copy link
Contributor Author

keithchong commented Feb 11, 2022

Hey @reginapizza , it looks like you are saying that the vertical scrollbar height is no longer reaching to the very top of the page. The height of the viewable area is limited to that 'scrollable' viewable tree section. So the vertical scrollbar is visible there and no longer includes the status panel. Another way to look at it is, the status panel is not scrolled since it is permanent, and only the tree is scrolled.

Note, this PR does not change the width of the viewable scrollable. The horizontal scrollbar 'length' is still an issue but once the filter is moved to the side panel/margin (the PR that @rbreeze always wanted to get merged), then we won't have that issue.

@reginapizza
Copy link
Contributor

@keithchong I see, I'm okay with this solution then! LGTM 👍

Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @keithchong . Tried locally as well - looks great.

@alexmt alexmt merged commit 5b78654 into argoproj:master Mar 4, 2022
wojtekidd pushed a commit to wojtekidd/argo-cd that referenced this pull request Apr 25, 2022
… (argoproj#8462)

Signed-off-by: Keith Chong <kykchong@redhat.com>
Signed-off-by: wojtekidd <wojtek.cichon@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Horizontal Scrolling doesn't appear until page end
3 participants