feat: dex subcommand logformat/loglevel flags (#8524) #8542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krrrr38
changed the title
krrrr38
force-pushed
the
dex-log-flags
branch
from
7bf5a5a
to
1173bb3
Compare
Codecov Report
@@ Coverage Diff @@
## master #8542 +/- ##
==========================================
- Coverage 45.53% 45.51% -0.02%
==========================================
Files 219 219
Lines 25897 25897
==========================================
- Hits 11792 11787 -5
- Misses 12463 12467 +4
- Partials 1642 1643 +1
Continue to review full report at Codecov.
|
Signed-off-by: krrrr38 <k.kaizu38@gmail.com>
krrrr38
force-pushed
the
dex-log-flags
branch
from
1173bb3
to
4185619
Compare
|
Looks like I need to investigate a flaky e2e test. |
wojtekidd
pushed a commit
to wojtekidd/argo-cd
that referenced
this pull request
Apr 25, 2022
Signed-off-by: krrrr38 <k.kaizu38@gmail.com> Co-authored-by: Michael Crenshaw <michael@crenshaw.dev> Signed-off-by: wojtekidd <wojtek.cichon@protonmail.com>
|
Can't see this one in the changelog. Will it make it in 2.4 ? Do you have any ETA for general availability ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: krrrr38 k.kaizu38@gmail.com
Closes #8524
Motivation
argocd-dex rundexoutput both text and json logs. And it cannot change log format inrundexsubcommand.Changes
logformat/loglevel options are available on argocd-dex subcommands.
$ go run main.go rundex --logformat json {"level":"fatal","msg":"exec: \"dex\": executable file not found in $PATH","time":"2022-02-17T08:26:13+09:00"} exit status 20 $ go run main.go rundex --logformat text FATA[0000] exec: "dex": executable file not found in $PATH exit status 20Checklist:
Optional. My organization is added to USERS.md.I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.--logformat jsonexample above