fix(ui): pass getResource function to the extension component

[yq314]

This is an attempt to address argoproj-labs/argocd-extensions#10

When workloadRef is used in Rollout resource, the extension is not able to access spec.template as it's defined in the Deployment resource. We need additional call to the api to fetch necessary information from Deployment.

The fix is to pass the getResource() function to the extension component.

I clearly miss a lot of contexts and background knowledge of the project, let me know if the attempt doesn't make sense and I'm happy to update the implementation.

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
• The title of the PR states what changed and the related issues number (used for the release note).
• I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
• I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
• Does this PR require documentation updates?
• I've updated documentation as required by this PR.
• Optional. My organization is added to USERS.md.
• I have signed off all my commits as required by DCO
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My build is green (troubleshooting builds).

[yq314]

@rbreeze @alexmt could you take a look thanks

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0a46d37) 42.64% compared to head (97cd4ab) 42.66%.
Report is 2312 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #8617      +/-   ##
==========================================
+ Coverage   42.64%   42.66%   +0.01%     
==========================================
  Files         184      184              
  Lines       23130    23130              
==========================================
+ Hits         9864     9868       +4     
+ Misses      11862    11859       -3     
+ Partials     1404     1403       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[rbreeze]

I'm not sure it's best to encourage the extension to request any resource from the API.

However, I see why you took this approach, as Argo CD cannot predict what other resources the extension might need. The extension already receives the tree data, which contains all the necessary resources (including a Deployment referenced by workloadRef).

Two alternative approaches:

1. Pass a map of resources instead of a function here, such that accessing the map at resourceMap[resource] returns the same thing as services.applications.getResource(application.metadata.name, resource)
2. Don't make any changes to Argo CD, but rather change the Rollout extension to parse the tree for the relevant deployment when a workloadRef is being used

I prefer the second solution, as the Rollout extension already has all the data it needs. @alexmt what are your thoughts?

[yq314]

@rbreeze the second solution was actually the first approach I attempted, however, the tree doesn't have all the information we need.

This is the deployment in tree:

{
  createdAt: "2022-03-01T11:03:34Z",
  group: "apps",
  health: { status: "Healthy" },
  info: [{ name: "Revision", value: "Rev:1" }],
  kind: "Deployment",
  name: "pice-service",
  namespace: "pricing",
  resourceVersion: "71769635",
  uid: "bbffaa75-ae9f-44da-88d9-a817fa0fd70d",
  version: "v1",
}

We still don't have access to the spec of deployment. We do need the information in tree to call the getResource() function.

It looks like solution 1 is more viable, or can we actually just enrich the items in the tree with what is returned in services.applications.getResource(application.metadata.name, resource) ?

[mihstaub]

Hey guys,

Any update on this pr?

[christianh814]

Hey guys,

Any update on this pr?

Looks like we're still waiting for @yq314 and @rbreeze to resolve conflicts

[kencochrane]

@rbreeze, do you have a few minutes to help with this? If not, let us know, and we can see if we can find someone else.

[rbreeze]

@kencochrane Sure thing, I should have some time this week