Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Minor cleanup for app errors #5273 #8623

Merged
merged 1 commit into from
Mar 15, 2022
Merged

fix: Minor cleanup for app errors #5273 #8623

merged 1 commit into from
Mar 15, 2022

Conversation

emagana-zz
Copy link
Contributor

@emagana-zz emagana-zz commented Feb 28, 2022 •
edited
Loading

fix: Minor cleanup for app errors
Closes [ISSUE #5273]
First timer commit to fix a gramma issue

Signed-off-by: Edgar Magana emagana@gmail.com

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

@codecov
Copy link

codecov bot commented Feb 28, 2022 •
edited
Loading

Codecov Report

Merging #8623 (35ea8c6) into master (b7912ac) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8623      +/-   ##
==========================================
- Coverage   42.66%   42.64%   -0.02%     
==========================================
  Files         184      183       -1     
  Lines       23130    22961     -169     
==========================================
- Hits         9868     9792      -76     
+ Misses      11859    11786      -73     
+ Partials     1403     1383      -20
Impacted Files Coverage Δ
controller/clusterinfoupdater.go 35.59% <0.00%> (ø)
util/app/discovery/discovery.go 46.77% <0.00%> (-1.67%) ⬇️
util/argo/argo.go 63.11% <0.00%> (-0.99%) ⬇️
pkg/apis/application/v1alpha1/types.go 54.46% <0.00%> (-0.62%) ⬇️
cmd/argocd/commands/app.go 0.53% <0.00%> (-0.01%) ⬇️
util/settings/settings.go 47.91% <0.00%> (ø)
cmd/argocd/commands/version.go 0.00% <0.00%> (ø)
util/ksonnet/ksonnet.go
reposerver/repository/repository.go 57.90% <0.00%> (+0.50%) ⬆️
cmd/util/app.go 50.40% <0.00%> (+3.30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7912ac...35ea8c6. Read the comment docs.

pasha-codefresh
pasha-codefresh approved these changes Mar 1, 2022
View reviewed changes
Copy link
Member

@pasha-codefresh pasha-codefresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you

crenshaw-dev
crenshaw-dev approved these changes Mar 1, 2022
View reviewed changes
Copy link
Member

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Can you follow these instructions to signoff the commit? https://github.com/argoproj/argo-cd/pull/8623/checks?check_run_id=5366665713

@emagana-zz
Copy link
Contributor Author

I have added the sign-off. Thanks!

@crenshaw-dev
Copy link
Member

@emagana are you sure you force-pushed the signed-off commit? DCO still shows as failing.

@emagana-zz
Copy link
Contributor Author

No, no yet. Sorry got distracted with other work.. will do it ASAP

@emagana
fix: Minor cleanup for app errors argoproj#5273
35ea8c6 
First timer commit to fix a gramma issue

Signed-off-by: Edgar Magana <emagana@gmail.com>
@emagana-zz
Copy link
Contributor Author

The force-pushed the signed-off commit is done. Thanks!

@emagana-zz
Copy link
Contributor Author

@crenshaw-dev Could you merge this PR? Thank you!

@crenshaw-dev
Copy link
Member

@emagana I don't have merge permissions, but someone who does should get to this before long. :-)

jannfis
jannfis approved these changes Mar 15, 2022
View reviewed changes
Copy link
Member

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jannfis jannfis merged commit 48cf001 into argoproj:master Mar 15, 2022
wojtekidd pushed a commit to wojtekidd/argo-cd that referenced this pull request Apr 25, 2022
@emagana @wojtekidd
fix: Minor cleanup for app errors argoproj#5273 (argoproj#8623)
16ecdf9 
First timer commit to fix a gramma issue

Signed-off-by: Edgar Magana <emagana@gmail.com>
Signed-off-by: wojtekidd <wojtek.cichon@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pasha-codefresh pasha-codefresh pasha-codefresh approved these changes

@jannfis jannfis jannfis approved these changes

@crenshaw-dev crenshaw-dev crenshaw-dev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@emagana-zz @crenshaw-dev @jannfis @pasha-codefresh @emagana