Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix Traefik IngressRoute CRD to prevent missing required field "name" #8950 #8951

Merged
merged 1 commit into from
Apr 7, 2022

Conversation

jonashackt
Copy link
Contributor

@jonashackt jonashackt commented Mar 31, 2022

Fixes #8950

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

@jonashackt jonashackt changed the title Fixing Traefik IngressRoute CRD to prevent missing required field "name" docs: fix Traefik IngressRoute CRD to prevent missing required field "name" Mar 31, 2022
@jonashackt jonashackt changed the title docs: fix Traefik IngressRoute CRD to prevent missing required field "name" docs: fix Traefik IngressRoute CRD to prevent missing required field "name" #8950 Mar 31, 2022
@codecov
Copy link

codecov bot commented Mar 31, 2022

Codecov Report

Merging #8951 (438d9ab) into master (0ff1ada) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #8951      +/-   ##
==========================================
- Coverage   44.96%   44.92%   -0.05%     
==========================================
  Files         212      212              
  Lines       25261    25261              
==========================================
- Hits        11359    11348      -11     
- Misses      12295    12309      +14     
+ Partials     1607     1604       -3     
Impacted Files Coverage Δ
applicationset/services/scm_provider/github.go 63.52% <0.00%> (-17.65%) ⬇️
util/settings/settings.go 48.10% <0.00%> (ø)
applicationset/services/scm_provider/utils.go 88.50% <0.00%> (+4.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ff1ada...438d9ab. Read the comment docs.

…name

Signed-off-by: Jonas Hecht <jonas.hecht@codecentric.de>
@iam-veeramalla iam-veeramalla self-requested a review April 1, 2022 07:46
@iam-veeramalla
Copy link
Member

@jonashackt, Thanks for the PR. Your changes looks good to me. options field in the Traefik IngressRoute CRD is only required when a user wants to configure TLS options.

Do you want to add a link to the Traefik IngressRoute CRD documentation ? so that a user can refer the documentation for more options available.

Copy link
Member

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to go ahead and merge since this has been sitting a while. If someone wants to open a follow-up PR with a docs link, we'll happily merge that too. :-)

@crenshaw-dev crenshaw-dev merged commit 4ce1091 into argoproj:master Apr 7, 2022
@jonashackt jonashackt deleted the patch-1 branch April 8, 2022 07:22
ashutosh16 pushed a commit to ashutosh16/argo-cd that referenced this pull request Apr 9, 2022
…name (argoproj#8951)

Signed-off-by: Jonas Hecht <jonas.hecht@codecentric.de>
Signed-off-by: asingh51 <Ashutosh_Singh@intuit.com>
wojtekidd pushed a commit to wojtekidd/argo-cd that referenced this pull request Apr 25, 2022
…name (argoproj#8951)

Signed-off-by: Jonas Hecht <jonas.hecht@codecentric.de>
Signed-off-by: wojtekidd <wojtek.cichon@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants