Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve timeout.reconciliation error handling #8964

Conversation

ragnarpa
Copy link
Contributor

@ragnarpa ragnarpa commented Apr 1, 2022

  • Improve error handling of invalid input for timeout.reconciliation.
  • Update docs for expected format of timeout.reconciliation.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

@ragnarpa ragnarpa force-pushed the improve-timeout-reconciliation-error-handling branch from 33004ff to 660a85a Compare April 1, 2022 06:54
@codecov
Copy link

codecov bot commented Apr 1, 2022

Codecov Report

Merging #8964 (e4e5c88) into master (e9fae0d) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

❗ Current head e4e5c88 differs from pull request most recent head f54ee8a. Consider uploading reports for the commit f54ee8a to get more accurate results

@@            Coverage Diff             @@
##           master    #8964      +/-   ##
==========================================
- Coverage   44.96%   44.88%   -0.08%     
==========================================
  Files         212      212              
  Lines       25264    25264              
==========================================
- Hits        11361    11341      -20     
- Misses      12296    12316      +20     
  Partials     1607     1607              
Impacted Files Coverage Δ
util/env/env.go 90.90% <100.00%> (ø)
applicationset/services/scm_provider/github.go 57.64% <0.00%> (-23.53%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9fae0d...f54ee8a. Read the comment docs.

@ragnarpa ragnarpa force-pushed the improve-timeout-reconciliation-error-handling branch from 660a85a to e4e5c88 Compare April 1, 2022 11:16
Signed-off-by: Ragnar Paide <ragnar.paide@gmail.com>
@ragnarpa ragnarpa force-pushed the improve-timeout-reconciliation-error-handling branch from e4e5c88 to f54ee8a Compare April 1, 2022 12:12
Copy link
Member

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@crenshaw-dev crenshaw-dev merged commit 3659b7b into argoproj:master Apr 1, 2022
wojtekidd pushed a commit to wojtekidd/argo-cd that referenced this pull request Apr 25, 2022
Signed-off-by: Ragnar Paide <ragnar.paide@gmail.com>
Signed-off-by: wojtekidd <wojtek.cichon@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants