-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Make spec.source.helm.values field accepts either a string or a rawExtension #9079
feat: Make spec.source.helm.values field accepts either a string or a rawExtension #9079
Conversation
Signed-off-by: Mohamed Chiheb <mc.benjemaa@gmail.com>
Signed-off-by: Mohamed Chiheb <mc.benjemaa@gmail.com>
…g or object Signed-off-by: Mohamed Chiheb <mc.benjemaa@gmail.com>
Signed-off-by: Mohamed Chiheb <mc.benjemaa@gmail.com>
Signed-off-by: Mohamed Chiheb <mc.benjemaa@gmail.com>
Signed-off-by: Mohamed Chiheb <mc.benjemaa@gmail.com>
Signed-off-by: Mohamed Chiheb <mc.benjemaa@gmail.com>
Signed-off-by: Mohamed Chiheb <mohamed.chiheb-extern@renault.com>
…e2e that sets values as raw via this flag Signed-off-by: Mohamed Chiheb <mc.benjemaa@gmail.com> Signed-off-by: Mohamed Chiheb <mohamed.chiheb-extern@renault.com> Signed-off-by: Mohamed Chiheb <mc.benjemaa@gmail.com>
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
Codecov ReportBase: 45.51% // Head: 45.57% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #9079 +/- ##
==========================================
+ Coverage 45.51% 45.57% +0.06%
==========================================
Files 217 218 +1
Lines 25663 25715 +52
==========================================
+ Hits 11680 11720 +40
- Misses 12355 12368 +13
+ Partials 1628 1627 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
Curious if this will make it into 2.4? |
@tiagomeireles I doubt it. It's very close, but I want to try using a |
Closing until I have time to give this another shot. |
seeking for this feature 😞 |
Taking volunteers to pick this back up! I'd happily provide guidance. Just don't have time to finish it. |
@crenshaw-dev I would like to pick this up 👋 |
@alexef brilliant, lmk how I can help! |
#8794 plus some changes I'd requested.
Fixes #2936
This change makes it possible to store either a string or a map in
spec.source.helm.values
. Using a map will allow people to kustomize-patch the values field.