Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update 2.3 notes - mention helm chart #9512

Merged
merged 1 commit into from
May 30, 2022

Conversation

asfaltboy
Copy link
Contributor

@asfaltboy asfaltboy commented May 25, 2022

Spent some time looking this up, as we use the helm chart. I believe values should be copied as-is into the notifications section of the argo-cd chart. Please correct me if I'm wrong in this assumption


Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

the helm chart values should be copied as-is into the `notifications` section of the argo-cd chart

Signed-off-by: Pavel Savchenko <asfaltboy@gmail.com>
@asfaltboy asfaltboy marked this pull request as ready for review May 25, 2022 16:45
@codecov
Copy link

codecov bot commented May 25, 2022

Codecov Report

Merging #9512 (1ef049c) into master (7faae31) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #9512   +/-   ##
=======================================
  Coverage   45.75%   45.75%           
=======================================
  Files         221      221           
  Lines       26293    26293           
=======================================
  Hits        12031    12031           
  Misses      12606    12606           
  Partials     1656     1656           
Impacted Files Coverage Δ
util/settings/settings.go 48.16% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7faae31...1ef049c. Read the comment docs.

Copy link
Member

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for improving the docs, @asfaltboy !

@jannfis jannfis merged commit 95f0624 into argoproj:master May 30, 2022
@crenshaw-dev crenshaw-dev added the cherry-pick/2.4 Candidate for cherry picking into the 2.4 release branch label May 31, 2022
crenshaw-dev pushed a commit that referenced this pull request May 31, 2022
the helm chart values should be copied as-is into the `notifications` section of the argo-cd chart

Signed-off-by: Pavel Savchenko <asfaltboy@gmail.com>
@asfaltboy asfaltboy deleted the patch-1 branch May 14, 2023 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick/2.4 Candidate for cherry picking into the 2.4 release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants