fix(deps): remove incorrectly duplicated peerDeps #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- these are all inside of prod `dependencies` already (choose one) - notably, `antd` had a version mismatch between `dependencies` and `peerDependencies` (v5 vs v4) - `dependencies` supersede `peerDependencies` however, so the v5 dep was already used and the v4 dep was extraneous - see the [`yarn.lock` file](https://github.com/argoproj/argo-ui/blob/c65a9520366b0c0cf0ac585618d029e60041a94d/yarn.lock#L5124) as evidence, as well as a downstream `yarn.lock`, such as [Argo Workflows's](https://github.com/argoproj/argo-workflows/blob/93914261cff4216561c89c1f5f6123e7ad0d5f61/ui/yarn.lock#L2812) - note how this commit has no changes to the `yarn.lock` file either - this mismatch did cause install warnings downstream as well, which were impossible to resolve given this mismatch in `argo-ui`'s own deps - so those should now be resolved as well Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
agilgur5
added
type/dependencies
7 tasks
crenshaw-dev
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
these are all inside of prod
dependenciesalready (it has to be either or)notably,
antdhad a version mismatch betweendependenciesandpeerDependencies(and it was a major version difference, v5 vs v4 after build(deps): bump antd from 4.21.3 to 5.6.1 #387)dependenciessupersedepeerDependencieshowever, so the v5 dep was already used and the v4 dep was extraneousyarn.lockfile as evidence, as well as a downstreamyarn.lock, such as Argo Workflows'syarn.lockfile eitherargo-ui's own depsNoticed this in argoproj/argo-workflows#12097 (comment)
Modifications
Remove duplicate deps from
peerDependenciesinpackage.jsonVerification
No changes to
yarn.lock,yarn install, build etc all still work fine. CI passes