-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add label selectors to argo cron list
command
#11158
Labels
Comments
This would be a good enhancement. Would you like to contribute to it? |
I can't promise that I can deliver it in timely fashion but I can take a crack at it! |
dbragdon1
added a commit
to dbragdon1/argo-workflows
that referenced
this issue
Jun 10, 2023
Signed-off-by: Dylan Bragdon <dylan.bragdon@gmail.com>
dbragdon1
added a commit
to dbragdon1/argo-workflows
that referenced
this issue
Jun 11, 2023
Signed-off-by: Dylan Bragdon <dylan.bragdon@gmail.com>
dbragdon1
added a commit
to dbragdon1/argo-workflows
that referenced
this issue
Jun 26, 2023
Signed-off-by: Dylan Bragdon <dylan.bragdon@gmail.com>
dbragdon1
added a commit
to dbragdon1/argo-workflows
that referenced
this issue
Jun 26, 2023
Signed-off-by: Dylan Bragdon <dylan.bragdon@gmail.com>
terrytangyuan
pushed a commit
that referenced
this issue
Jun 26, 2023
JPZ13
pushed a commit
to pipekit/argo-workflows
that referenced
this issue
Jul 4, 2023
…rgoproj#11202) Signed-off-by: Dylan Bragdon <dylan.bragdon@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary
My team has many different cronworkflows, and we often use the
argo cron list
command to summarize them. Sometimes we wish to only view different groups of related workflows, which we cluster together using kubernetes labels. We really like the functionality ofargo cron list
for the information it provides regarding last runs, next runs, etc, but sometimes we only want to select a subset of cronworkflows based on specific labels. Currently our solution is to pipe the output ofargo cron list
to something likegrep
, but this only allows us to filter the result based on the name of the cronworkflow.I would like for there to be a label selector option when using the
argo cron list
command. I imagine it would look something like this:Where these labels are stored in the metadata of the cronworkflow itself:
What change needs making?
It appears that there is a
labelSelector
being used inargo-workflows/cmd/argo/commands/cron/list.go
Line 41 in 58793a8
Perhaps this can be extended to appropriate the labels passed by the user before querying the kubernetes cluster for existing cronworkflows?
Use Cases
When would you use this?
As noted above, it would be quite useful to utilize label selectors when querying for cronworkflows, especially when teams like ours have many, in order to give a glimpse at how certain "groups" of cronworkflows are running in our cluster. As another example, if a team has multiple cron workflows related to a specific use case, such as all cronworkflows configured for a specific business client, it would be useful use label selectors to grab all cronworkflows related to that client, in order to get an easily readable summary, rather than the entire list of cronworkflows in your cluster/namespace.
Thank you argo team for your time and for an amazing product!
Message from the maintainers:
Love this enhancement proposal? Give it a 👍. We prioritise the proposals with the most 👍.
The text was updated successfully, but these errors were encountered: