feat: enable configuration for finalizer removal if artifact GC fails #10810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julie Vogelmani <julie_vogelman@intuit.com>
Signed-off-by: Julie Vogelmani <julie_vogelman@intuit.com>
Signed-off-by: Julie Vogelmani <julie_vogelman@intuit.com>
Signed-off-by: Julie Vogelmani <julie_vogelman@intuit.com>
Signed-off-by: Julie Vogelmani <julie_vogelman@intuit.com>
Signed-off-by: Julie Vogelmani <julie_vogelman@intuit.com>
Signed-off-by: Julie Vogelmani <julie_vogelman@intuit.com>
Signed-off-by: Julie Vogelmani <julie_vogelman@intuit.com>
Signed-off-by: Julie Vogelmani <julie_vogelman@intuit.com>
Signed-off-by: Julie Vogelmani <julie_vogelman@intuit.com>
Signed-off-by: Julie Vogelmani <julie_vogelman@intuit.com>
Signed-off-by: Julie Vogelmani <julie_vogelman@intuit.com>
3 tasks
Signed-off-by: Julie Vogelmani <julie_vogelman@intuit.com>
Signed-off-by: Julie Vogelmani <julie_vogelman@intuit.com>
terrytangyuan
approved these changes
Apr 7, 2023
5 tasks
JPZ13
pushed a commit
to pipekit/argo-workflows
that referenced
this pull request
Jul 4, 2023
…argoproj#10810) Signed-off-by: Julie Vogelmani <julie_vogelman@intuit.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10788
Why: some users seem to want their Workflows to be deletable when Artifact GC fails (through other means besides
argo delete --force). The idea is to make it something that's configurable.What:
I considered:
I tried both the 1st and 2nd options. The 1st was a possibility but it seemed to probably be unnecessary in that users won't need different configurability for different artifacts. It also meant needing to make the field something other than a boolean, since otherwise you can't really distinguish between:
wfLevel: forceFinalizerRemoval=true, artifactLevel: forceFinalizerRemoval=false, andwfLevel: forceFinalizerRemoval=true, artifactLevel: forceFinalizerRemoval not setI went with the 2nd option.
Testing: Expanded the e2e test to test whether the finalizer was removed when ArtifactGC failed both when
forceFinalizerRemovalwas set to true and when it was set to false.