build: upgrade to use nodev20 #11410

chenrui333 · 2023-07-20T21:16:11Z

👋 node 16 is gonna be EOL on 11 Sep 2023, right now, building with node v20 would have digital envelope routines::unsupported issue, thus updating the build to use v20.

closes #11404
relates to Homebrew/homebrew-core#137118

cc @templarfelix @JPZ13

Signed-off-by: Rui Chen <rui@chenrui.dev>

terrytangyuan · 2023-07-21T14:59:04Z

I remember you had a comment on the node version before, right? @jmeridth

terrytangyuan · 2023-07-21T14:59:40Z

@tczhao @JPZ13 Could you help review this?

jmeridth · 2023-07-21T19:18:00Z

@terrytangyuan was regarding #10126

my issue was that I was able to get a feature working with v18 and then we (argo-workflows) went back to v16. Feature broke. Going to v20 would be awesome.

terrytangyuan · 2023-07-23T17:25:20Z

Thanks.

Please fix the CI build failures.

agilgur5

A few other places we should update too, like the Nixfiles in dev/nix/flake.nix.
EDIT: actually in flake.nix not node-env.nix, my bad. See below comments

agilgur5 · 2023-07-24T20:36:55Z

ui/package.json

@@ -6,7 +6,7 @@
        "src"
    ],
    "scripts": {
-        "build": "rm -Rf dist && NODE_OPTIONS='' NODE_ENV=production webpack --mode production --config ./src/app/webpack.config.js",
+        "build": "rm -Rf dist && NODE_OPTIONS='--openssl-legacy-provider' NODE_ENV=production webpack --mode production --config ./src/app/webpack.config.js",
        "start": "NODE_OPTIONS='--no-experimental-fetch' webpack-dev-server --config ./src/app/webpack.config.js",
        "lint": "tslint --fix -p ./src/app",
        "test": "jest"


on line 15 below, engines.node should be updated as well

let me add that.

Signed-off-by: Rui Chen <rui@chenrui.dev>

chenrui333 · 2023-07-26T04:37:09Z

A few other places we should update too, like the Nixfiles in dev/nix/node-env.nix

do you have any guide about it?

Signed-off-by: Rui Chen <rui@chenrui.dev>

agilgur5 · 2023-07-26T05:34:32Z

do you have any guide about it?

My bad, it's actually in flake.env. My Nix is very rusty but I can pull up something tomorrow probably.

If you're not sure, I'm ok approving without so long as CI passes. This is a good change to have and we can update Nix in a follow-up PR 🙂

isubasinghe · 2023-07-26T05:38:21Z

@agilgur5 I can push the Nix stuff, I was the one who ported the build process over to Nix.
Should be a simple 5 min job on my end.

isubasinghe · 2023-07-26T10:21:57Z

@terrytangyuan I think the build issues are not related to this PR.
I've got the same exact issues in my PR, likely flaky tests.

EDIT:
There are other issues as @alexec points out below.

alexec · 2023-07-26T15:00:50Z

Build error is this: "Error: error:0308010C:digital envelope routines::unsupported"

alexec · 2023-07-26T15:01:38Z

ui/package.json

alexec · 2023-07-26T15:08:48Z

@isubasinghe have you considered presenting on Nix to community meeting? Nix is new hotness.

Signed-off-by: Alex Collins <alexec@users.noreply.github.com>

isubasinghe · 2023-07-27T03:11:38Z

@alexec unfortunately my timezone makes attending the community meetings near impossible :(

terrytangyuan · 2023-07-27T14:36:31Z

https://github.com/argoproj/argo-workflows/actions/runs/5676115276/job/15382363976

error argo-ui@1.0.0: The engine "node" is incompatible with this module. Expected version ">=20". Got "18.17.0"

Would anyone like to help fix that CI failure?

terrytangyuan · 2023-07-27T14:49:39Z

Tracking in #11459

agilgur5 · 2023-07-27T16:02:21Z

Ah, this is from the snyk workflow, not ci-build. I'll make a PR for that

agilgur5 · 2023-07-28T20:42:27Z

Nix is new hotness.

2 decades for some more mainstream attention 😅

@alexec unfortunately my timezone makes attending the community meetings near impossible :(

I have yet to go to one but I imagine you could pre-record something which could just be played during the meeting?
@isubasinghe Also regarding NPM, did you use node2nix to generate the Nix expressions? It looks vaguely similar, but docs don't mention it. Last time I used Nix, I think NPM didn't exist yet 😅 (back when Node was still up-and-coming and the iojs fork happened etc etc)

isubasinghe · 2023-07-30T02:58:43Z

@agilgur5 I did use node2nix, its a bit of a manual process to use it with flakes however.
Probably not the best actually, I am planning to rewrite it using mkDerivation.
node2nix was just a quicker way of getting something up.

Also yeah I think I could probably pre-record something instead, will talk to someone about this later.

Signed-off-by: Rui Chen <rui@chenrui.dev> Signed-off-by: Alex Collins <alexec@users.noreply.github.com> Co-authored-by: Yuan Tang <terrytangyuan@gmail.com> Co-authored-by: Alex Collins <alexec@users.noreply.github.com>

Signed-off-by: isubasinghe <isitha@pipekit.io>

Signed-off-by: Rui Chen <rui@chenrui.dev> Signed-off-by: Alex Collins <alexec@users.noreply.github.com> Co-authored-by: Yuan Tang <terrytangyuan@gmail.com> Co-authored-by: Alex Collins <alexec@users.noreply.github.com> Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>

deps: upgrade to use nodev20

c1044f9

Signed-off-by: Rui Chen <rui@chenrui.dev>

agilgur5 reviewed Jul 24, 2023

View reviewed changes

update engine requirement

7e71cad

Signed-off-by: Rui Chen <rui@chenrui.dev>

chenrui333 changed the title ~~deps: upgrade to use nodev20~~ build: upgrade to use nodev20 Jul 26, 2023

remove --openssl-legacy-provider for workflow

784c92d

Signed-off-by: Rui Chen <rui@chenrui.dev>

Merge branch 'master' into build-with-nodev20

2590bf9

alexec reviewed Jul 26, 2023

View reviewed changes

ui/package.json Outdated Show resolved Hide resolved

Update ui/package.json

d4a47ad

Signed-off-by: Alex Collins <alexec@users.noreply.github.com>

terrytangyuan approved these changes Jul 27, 2023

View reviewed changes

terrytangyuan merged commit d876464 into argoproj:master Jul 27, 2023
22 checks passed

agilgur5 mentioned this pull request Jul 27, 2023

ci: fix snyk.yaml and release.yaml for Node v20 #11461

Merged

isubasinghe mentioned this pull request Aug 2, 2023

build: update node to v20 in nix flakes. Fixes #11410 #11506

Merged

terrytangyuan mentioned this pull request Aug 9, 2023

Release v3.4.10 cherry-pick candidates #11552

Closed

45 tasks

terrytangyuan pushed a commit that referenced this pull request Aug 21, 2023

build: update node to v20 in nix flakes. Fixes #11410 (#11506)

3e69e65

Signed-off-by: isubasinghe <isitha@pipekit.io>

agilgur5 added type/dependencies PRs and issues specific to updating dependencies area/build Build or GithubAction/CI issues javascript Pull requests that update Javascript dependencies labels Aug 31, 2023

This was referenced Jan 6, 2024

Update Node.js version on CI argoproj/argo-ui#432

Closed

build(ui): remove no longer needed --openssl-legacy-provider #12480

Merged

agilgur5 added the area/ui label Jan 7, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

build: upgrade to use nodev20 #11410

build: upgrade to use nodev20 #11410

chenrui333 commented Jul 20, 2023

terrytangyuan commented Jul 21, 2023 •

edited

Loading

terrytangyuan commented Jul 21, 2023

jmeridth commented Jul 21, 2023

terrytangyuan commented Jul 23, 2023

agilgur5 left a comment •

edited

Loading

agilgur5 Jul 24, 2023

chenrui333 Jul 26, 2023

chenrui333 commented Jul 26, 2023

agilgur5 commented Jul 26, 2023

isubasinghe commented Jul 26, 2023

isubasinghe commented Jul 26, 2023 •

edited

Loading

alexec commented Jul 26, 2023

alexec commented Jul 26, 2023

alexec commented Jul 26, 2023

isubasinghe commented Jul 27, 2023

terrytangyuan commented Jul 27, 2023 •

edited

Loading

terrytangyuan commented Jul 27, 2023

agilgur5 commented Jul 27, 2023

agilgur5 commented Jul 28, 2023 •

edited

Loading

isubasinghe commented Jul 30, 2023

build: upgrade to use nodev20 #11410

build: upgrade to use nodev20 #11410

Conversation

chenrui333 commented Jul 20, 2023

terrytangyuan commented Jul 21, 2023 • edited Loading

terrytangyuan commented Jul 21, 2023

jmeridth commented Jul 21, 2023

terrytangyuan commented Jul 23, 2023

agilgur5 left a comment • edited Loading

Choose a reason for hiding this comment

agilgur5 Jul 24, 2023

Choose a reason for hiding this comment

chenrui333 Jul 26, 2023

Choose a reason for hiding this comment

chenrui333 commented Jul 26, 2023

agilgur5 commented Jul 26, 2023

isubasinghe commented Jul 26, 2023

isubasinghe commented Jul 26, 2023 • edited Loading

alexec commented Jul 26, 2023

alexec commented Jul 26, 2023

alexec commented Jul 26, 2023

isubasinghe commented Jul 27, 2023

terrytangyuan commented Jul 27, 2023 • edited Loading

terrytangyuan commented Jul 27, 2023

agilgur5 commented Jul 27, 2023

agilgur5 commented Jul 28, 2023 • edited Loading

isubasinghe commented Jul 30, 2023

terrytangyuan commented Jul 21, 2023 •

edited

Loading

agilgur5 left a comment •

edited

Loading

isubasinghe commented Jul 26, 2023 •

edited

Loading

terrytangyuan commented Jul 27, 2023 •

edited

Loading

agilgur5 commented Jul 28, 2023 •

edited

Loading