ci: fix snyk.yaml and release.yaml for Node v20
#11461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- node was updated in `ci-build.yaml` but not `synk.yaml`
- caused Snyk to (correctly) error on the `node.engines` requirement
- see https://github.com/argoproj/argo-workflows/actions/runs/5676115276/job/15382363976
Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
- it is already set in-line in the `package.json`, so no need to set it globally as an env var - setting it as an env var also breaks GH's default runner version that runs for `checkout`: https://github.com/argoproj/argo-workflows/actions/runs/5676125574/job/15383405669 - this was removed from some of the GH workflows during the node v20 upgrade original PR's iteration, but this one reference seems to have been left in Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
terrytangyuan
approved these changes
Jul 27, 2023
|
Thanks! |
45 tasks
terrytangyuan
pushed a commit
that referenced
this pull request
Aug 11, 2023
Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
agilgur5
added
type/dependencies
dpadhiar
pushed a commit
to dpadhiar/argo-workflows
that referenced
this pull request
May 9, 2024
Signed-off-by: Anton Gilgur <agilgur5@gmail.com> Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11459 , Fixes #11410 (comment)
Motivation
There was some breakage in different CI workflows due to the node v20 upgrade in #11410
ci-build.yamlbut notsynk.yamlnode.enginesrequirement--openssl-legacy-providerwas set inrelease.yaml'sNODE_OPTIONSenv, but not the otherspackage.json, so no need to set it globally as an env varcheckout: https://github.com/argoproj/argo-workflows/actions/runs/5676125574/job/15383405669Modifications
actions/setup-node@v3withnode-version: "20"tosnyk.yaml--openssl-legacy-providerfromrelease.yamlVerification
CI build should pass now
Future Work
Ideally, we should update more NPM deps so that this flag is not needed