-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add terrytangyuan
to list of approvers
#6963
Conversation
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #6963 +/- ##
==========================================
+ Coverage 48.49% 48.53% +0.04%
==========================================
Files 265 265
Lines 19267 19267
==========================================
+ Hits 9343 9352 +9
+ Misses 8873 8860 -13
- Partials 1051 1055 +4
Continue to review full report at Codecov.
|
I would also like to sponsor Terry! |
I sponsor this too. |
terrytangyuan
to list of approvers
@sarabala1979 as project lead, do you have any objections? If not, then we can merge and I'll update Github permissions to allow @terrytangyuan to approve and merge PRs. |
Correction, the leads, as defined by the OWNERS file are:
@alexmt @VaibhavPage can I ask if you object to @terrytangyuan becoming an approver? @sarabala1979 it would still be great to get your blessing. |
I also sponsor Terry
…On Tue, Oct 19, 2021 at 7:40 AM Alex Collins ***@***.***> wrote:
I sponsor this too.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#6963 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AICWOVDXCMGYPUYPGILSRJ3UHV7MFANCNFSM5GH5FJ2A>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
--
Thanks & Regards
Saravanan
|
I approve of Terry as the approver. Congrats Terry. |
+1 from me! |
+1 from as well |
Thank you all for your sponsorship, support, and trust! |
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> Signed-off-by: kriti-sc <kathuriakriti1@gmail.com>
This PR moves myself to the list of approvers as defined here.
Signed-off-by: Yuan Tang terrytangyuan@gmail.com