fix: Use v1 pod name if no template name or ref. Fixes #7595 and #7749

[JPZ13]

Signed-off-by: J.P. Zivalich jp@pipekit.io

This PR:

• Falls back to the v1 pod names in the UI if no templateName or templateRef is set on a given node - my hypothesis is that certain virtual nodes might not have a a templateName or templateRef set as seen here: v3.2.6 Argo UI failed to render pod log #7595 (comment)
• Fixes v3.2.6 Argo UI failed to render pod log #7595

@liuzqt Could you run one of your workflows locally using this PR branch to test if it is working? I want to validate that I don't have to make an additional change to the workflow controller

[JPZ13]

@alexec - We don't yet have an example to reproduce #7595. Once we hear back from @liuzqt's team and have confirmed that this PR fixes their use case, I'll convert it from a draft to ready to review

[terrytangyuan]

@JPZ13 Do you have an image for them to test out? I am in touch with their team. Let me know if there’s any other information you need.

[JPZ13]

@JPZ13 Do you have an image for them to test out? I am in touch with their team. Let me know if there’s any other information you need.

Thanks @terrytangyuan - I cut three images and pushed them to our organization's docker registry since I don't have push access to the argoproj one. Here are the image tags:

• pipekit13/workflow-controller:fix-log-render-v1
• pipekit13/argoexec:fix-log-render-v1
• pipekit13/argocli:fix-log-render-v1

Let me know if they're able to run those or if they run into any issues

[terrytangyuan]

Let me know if they're able to run those or if they run into any issues

Thanks. We'll test it out.

[JPZ13]

@terrytangyuan - have y'all had a chance to test these out yet?

[terrytangyuan]

@terrytangyuan - have y'all had a chance to test these out yet?

Not yet. I'll check soon.

[JPZ13]

@alexec This PR fixes #7749. I hadn't had an example to test it with before, but I was able to test it with @Hunter-Thompson's example

[terrytangyuan]

Thanks @JPZ13!

[JPZ13]

Any time, @terrytangyuan!