Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TABS BELOW CONTENT SUPPORT THREAD] - tabs on windows bottom #33

Closed
gg2by2 opened this issue Nov 15, 2017 · 35 comments
Closed

[TABS BELOW CONTENT SUPPORT THREAD] - tabs on windows bottom #33

gg2by2 opened this issue Nov 15, 2017 · 35 comments

Comments

@gg2by2
Copy link

gg2by2 commented Nov 15, 2017

hello
what is the code to locate tabs at the bottom of the firefox 57 screen (just above the windows start button)?

it was suggested to try this=

/* Puts tabs on the bottom */
#TabsToolbar {
-moz-box-ordinal-group: 2;
border-bottom: 1px solid #888 !important;
}
#nav-bar{ border-top-width: 0px !important; }

but the tabs are still located near the top

@Aris-t2
Copy link
Owner

Aris-t2 commented Nov 15, 2017

@gg2by2
You can not move tabs toolbar to windows bottom. moz-box-ordinal-group only works within top toolbar box.

The only code that can do it heavily breaks Firefox ui and is not part of this project.

@Aris-t2 Aris-t2 changed the title how to locate tabs below firefox screen? Move tabs toolbar to windows bottom? Nov 15, 2017
@gg2by2
Copy link
Author

gg2by2 commented Nov 15, 2017 via email

@Aris-t2 Aris-t2 closed this as completed Nov 15, 2017
@ghost
Copy link

ghost commented Nov 16, 2017

The screen shot still shows tabs above the screen. Just received a response from the moderator that tabs below the screen CANNOT be done! That Firefox ui will not allow it!

Try - https://developer.mozilla.org/en-US/docs/Web/CSS/transform (many bugs to medium fix), many element transform blur fonts.

Or - position: fixed; bottom: 0 and remove bugs (hard to fix).

@Aris-t2 Aris-t2 changed the title Move tabs toolbar to windows bottom? [not part of this project] Move tabs toolbar to windows bottom? Nov 16, 2017
@ghost
Copy link

ghost commented Dec 3, 2017

https://github.com/Okamoi/UserChrome-Tweaks/blob/07a8f3faee59184b3c81e60a6506ad5680352ca9/toolbars/bottom-of-window-tabbar-Windows7.css - I test morning.

about:config ➡️ browser.tabs.drawInTitlebar false.

@Aris-t2 Aris-t2 changed the title [not part of this project] Move tabs toolbar to windows bottom? Move tabs toolbar to windows bottom? Dec 4, 2017
@Aris-t2
Copy link
Owner

Aris-t2 commented Dec 4, 2017

Is this working better than the one available?

@ghost
Copy link

ghost commented Dec 4, 2017

Is this working better than the one available?

Who knows, I do not used MixTabPlus and I was not looking this tweak in CustoCSSForFx or other project.


Bugged with:

  • fullscreen (description marciiF, Okamoi)

  • dpi +100% (if have appbutton on left in Windows)

  • no maximized window (if have appbutton on left in Windows)

  • no see menu toolbar ((description marciiF, Okamoi) any value "browser.tabs.drawInTitlebar")

    • image
    • image
    • image

Test on Windows 7 Aero / Basic / Classic (no test on Windows 10, GNU/Linux or MacOS).

screenshots browser.tabs.drawInTitlebar;true
browser.tabs.drawInTitlebar;true
MaximizedNormal

image

image

Classic Windows 7

image

image

screenshots browser.tabs.drawInTitlebar;false
browser.tabs.drawInTitlebar;false
MaximizedNormal

image

image

Classic Windows 7

image

image


Fonts is clear / spicy (not blur / fog), addons iframe works ok (e.g. uBlock Origin - element picker to block). Better than my first try to bottom.

@Aris-t2 Aris-t2 changed the title Move tabs toolbar to windows bottom? [TABS BELOW CONTENT SUPPORT THREAD] Dec 4, 2017
@Aris-t2 Aris-t2 reopened this Dec 4, 2017
@Aris-t2 Aris-t2 added DISCUSSION and removed invalid labels Dec 4, 2017
@Aris-t2
Copy link
Owner

Aris-t2 commented Dec 4, 2017

Switching browser.tabs.drawInTitlebar preference or changing Windows themes requires window maximizing/minimizing and/or a browser restart. Have you restarted Firefox after a change?
DPI of 200% is not officially supported on Windows. Even some default ui items don't scale properly.

@ghost
Copy link

ghost commented Dec 4, 2017

Nope, use only about:config tweak DPI value without restart FX.

@ghost
Copy link

ghost commented Dec 4, 2017

No works on Windows10 FCU (normal theme (no Classic, no Blur with third party software)), tomorow test with normal DPI windows 7 (reset with control panel and logout).

Windows 10, DPI 100% (normal): (wrong code / outdated) ⚠️
screenshots browser.tabs.drawInTitlebar;true
browser.tabs.drawInTitlebar;true
obraz
obraz
screenshots browser.tabs.drawInTitlebar;false
browser.tabs.drawInTitlebar;false
obraz
obraz
also no see menu toolbar
also no see menu toolbar
obraz

@Aris-t2
Copy link
Owner

Aris-t2 commented Dec 4, 2017

With Firefox DPI set to 200% (layout.css.devPixelsPerPx; 2.0) I did not see this issue. Haven't tried within Windows settings, as I don't have a HiDPI screen and setting to such a high value would make it impossible to use Windows for tests.

I remember when using VMs layout.css.devPixelsPerPx settings does not offer the same results real DPI changes in Windows setting do. There is always something different.

@ghost
Copy link

ghost commented Dec 4, 2017

I use 125% DPI (24" Full HD monitor). I try reset for first.


screenshot Bug - tabbar above windows task toolbar when menu toolbar active
(wrong code / outdated) ⚠️
Bug - tabbar above windows task toolbar when menu toolbar active
obraz

When use normal dpi in Control Panel - Classic Windows 7:
(wrong code / outdated) ⚠️

image | image | image |
image
---|---|---|---

Maybe HiDPI test if find user with this monitor - in my opinion glitch with browser.tabs.drawInTitlebar;true is not a bug with deflaut CustomCSSforFx.

@Aris-t2
Copy link
Owner

Aris-t2 commented Dec 5, 2017

  • I have set DPI to 125% in Windows 10FCU settings and rebooted
  • CustomCSSforFx 1.4.6
  • tested Firefox 57.0.1 and 59 Nightly
  • menubar on/off
  • titlebar on/off
  • dark/default themes
  • normal/maximized mode
  • uidensity compact/normal/touch

The glitch never occurred here. Are you sure there are no hiddden buttons on your tabs toolbar. They may cause different behavior.

Some screenshots

1
2
3
4
5

@ALL
Does anyone else has these kind of an issue?

@ghost
Copy link

ghost commented Dec 5, 2017

I create new profile firefox, download new chrome.zip 1.4.6, add ⚠️ delete ⚠️ code marciiF, Okamoi (possible this is guilty - old code for Firefox 55-56, not 57+).


Outdate info: I do not read comment about "tabs not on top" - no mistake this ⚠️

effect with mistake:

Classic
image
image
Areo
image
image
Basic
image
image

@import url(./css/tabs/tabs_below_navigation_toolbar.css); /**/
/*...*/
@import url(./css/tabs/tabs_below_main_content.css); /**/  /* <--- EXPERIMENTAL */

Works OK on Windows 7, I do test DPI 125%.

@Aris-t2
Copy link
Owner

Aris-t2 commented Dec 5, 2017

Why did you mix "other" code with this projects code while testing? Clearly this was not what I tested. :)

Yes, both tabs_below_navigation_toolbar.css and tabs_below_main_content.css have to be enabled, for things to work properly. I was too lazy to create more variations of tabs_below_main_content.css for other toolbar colors, but this might change with a future update.

@ghost
Copy link

ghost commented Dec 5, 2017

Why did you mix "other" code with this projects code while testing? Clearly this was not what I tested. :)

Use only outdated, no enable form CustomCSSforFx. I mistake in userChrome.css in changelog.


Added spoilers and warnings in old comments.


Works OK with higher dpi (125%) [after almost an hour everything seems to be even bigger with higher dpi - strange feeling - maybe reset in registry Windows DPI]

@ghost
Copy link

ghost commented Dec 5, 2017

Possible add lw-theme background instead / above black color (any position header image)?

obraz

other toolbar colors, but this might change with a future update.

OK.

@Aris-t2
Copy link
Owner

Aris-t2 commented Dec 5, 2017

On 1.4.7 release tabs_below_main_content.css imports tabs_below_navigation_toolbar.css. The description does not tell users to import 'tabs not on top' anymore. This should make thing more understandable. As a side effect users now can chose which predefined toolbar background color they want and select the corresponding tabs_below_main_content_XYZ.css file.

@Aris-t2 Aris-t2 changed the title [TABS BELOW CONTENT SUPPORT THREAD] [TABS BELOW CONTENT SUPPORT THREAD] - tabs on windows bottom Jan 19, 2018
@garywill
Copy link

I found tabs_below_main_content.css has problems on private window, buttons are messed.

Then simply I tried this js code

var tabsbar = document.getElementById("TabsToolbar");
const below_tabs = document.getElementById("browser-bottombox");
    
below_tabs.parentNode.appendChild(tabsbar, below_tabs);

and it works amazing. Just simply moved the entire tabbar object to bottom.
If you want to use this script, the css mustn't use toolbarbutton to execute js, or js will be executed repeatly when toolbar is changed.
Use

vbox#browser-bottombox {
  -moz-binding: url("./userChrome/userChrome.xml#execute_javascript_code");
}

instead.
I put the code here

@Aris-t2
Copy link
Owner

Aris-t2 commented Aug 12, 2018

@garywill
There is always room for improvement inside tabs_below_main_content.css. I will fix the glitch in private mode on next update.

Using this by the way great JS code/tweak to actually append tabs toolbar to browsers bottom box works, but might cause CSS code issues with code relying on default internal toolbar order. For some it will be the perfect solution, while it won't work for others.

@LilMarvellous
Copy link

@Aris-t2
Hello mate
i eventually sorted it using as text editor the humble Notepad for userChrome.css from custom_css_for_fx_v2.4.0 instead of the sophisticated Notepad++
It worked as charm
Thks for the pack!

@cxen
Copy link

cxen commented Jul 25, 2019

I have an issue with both "Tabs below nav bar" and "Multirow tabs".

On Firefox 68.0.1, with the same settings, CustomCSSforFx v2.6.2 is broken compared to using v2.4.9.

v2.4.9
2 4 9

v2.6.2
2 6 2

I've switched the appropriate lines on and off to achieve the same result (i.e. "****v3 for f68+" instead of "

***v2 for f65+") but it didn't fix the issue and even trying the exact same userChrome.css setup doesn't work.

@Aris-t2
Copy link
Owner

Aris-t2 commented Jul 25, 2019

The combination of tabs_below_navigation_toolbar_fx65_v2.css and tabs_multiple_lines_v3.css works fine here even on Fx70.

fx

@cxen
Copy link

cxen commented Jul 25, 2019

I tried again with a fresh chrome folder and 2.6.2 and still get a broken Firefox window with a glitchy title bar.

@Aris-t2
Copy link
Owner

Aris-t2 commented Jul 25, 2019

Different PC, FX 68.0.1, tabs_below_navigation_toolbar_fx65_v2.css and tabs_multiple_lines_v3.css, same result as before. I use the complete package with both options enabled in userChrome.css, make sure you do too, not just loose files...

@cxen
Copy link

cxen commented Jul 25, 2019

Not sure what you mean. My chrome folder has everything that the .zip file contains.

Edit: Deleted chrome folder again and created a new one with the contents of v2.6.2 and tabs_multiple_lines_v3.css (also without tabs_below_navigation_toolbar_fx65_v2.css) still gives me a broken browser. Have menu bar showing also.

@R8s6
Copy link

R8s6 commented Apr 8, 2020

In v3.0.5, when FF is unmaximized, and when @import "./css/tabs/tabs_below_navigation_toolbar_fx74.css"; /**/ is active, the tab doesn't line up with the horizontal separator, as the tab falls below the separator line. please see screenshot below:

This, however, is NOT present when the window is maximized, where the tab lines up perfectly with the separator line, as desired:

Steps to reproduce:
Activate:

@import "./config/general_variables.css"; /**/
@import "./css/tabs/tabs_below_navigation_toolbar_fx74.css"; /**/

All other options inactive.

Thanks!

@Aris-t2
Copy link
Owner

Aris-t2 commented Apr 9, 2020

This does not happen here. Which OS are you using? Tabs below navigation toolbar differentiates between macOS and Windows/Linux settings.

@R8s6
Copy link

R8s6 commented Apr 10, 2020

This does not happen here. Which OS are you using? Tabs below navigation toolbar differentiates between macOS and Windows/Linux settings.

Thanks for the reply. It’s Linux.

@Aris-t2
Copy link
Owner

Aris-t2 commented Apr 10, 2020

Looks like this for me even on Fx77:
image

Tested on Ubuntu.

@Aris-t2
Copy link
Owner

Aris-t2 commented Mar 18, 2022

I think this does not need to be an own discussion anymore. Main thread should be enough.
#454

@Aris-t2 Aris-t2 closed this as completed Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants