Include hyperlink action in PDF output for hyperlinks in webpage

[astefanutti]

…in webpage

[alexblack]

I'd love to see this in PhantomJS - does anyone know approx how long it might be until this shows up in binaries?

[Darijusch]

i would like to see this feature as well in phantomjs 👍

[oleghind]

+1 please merge asap

[aelgasser]

Thank you @astefanutti, I just applied your pull request to the base source code (fresh clone from the master of phantomjs) and it worked like a charm.

[astefanutti]

@aelgasser welcome, thanks for the feedback!

[S3bb1]

Can anyone build the Windows Version of this PR and send me a Link ?

[astefanutti]

@S3bb1 you can find a Windows binary containing this PR (among others https://github.com/astefanutti/phantomjs/commits/456d3a297c82b7cd91dd14d2ffb78cf81f74a921) at the following location: http://astefanutti.github.io/decktape/downloads/phantomjs-msvc2013-win64.exe. It's used for the decktape project.

[S3bb1]

thx @astefanutti for the fast answer!

[haydenbleasel]

+1, we need a merge 👍

[astefanutti]

Updated to support non ASCII characters in URLs.

[chiliec]

+1

[astefanutti]

@haydenbleasel If you managed to get a Ubuntu 14.04 build, that'd be great if you could upload it to the DeckTape download dir.

[haydenbleasel]

@astefanutti I installed all the required dependencies on a stock Ubuntu installation, followed the steps and ran build.sh and got this at the very end. Probably due to using a VM though, I'll try on my desktop later.

{standard input}: Assembler messages:
{standard input}:144571: Warning: end of file not at end of a line; newline inserted
{standard input}: Error: open CFI at the end of file; missing .cfi_endproc directive
g++: internal compiler error: Killed (program cc1plus)
Please submit a full bug report,
with preprocessed source if appropriate.
See <file:///usr/share/doc/gcc-4.8/README.Bugs> for instructions.
make[2]: *** [.obj/svg/SVGAllInOne.o] Error 4
make[2]: *** Waiting for unfinished jobs....
make[2]: Leaving directory `/home/parallels/Desktop/decktape/phantomjs/src/qt/qtwebkit/Source/WebCore'
make[1]: *** [sub-Target-pri-make_first-ordered] Error 2
make[1]: Leaving directory `/home/parallels/Desktop/decktape/phantomjs/src/qt/qtwebkit/Source/WebCore'
make: *** [sub-Source-WebCore-WebCore-pro-make_first-ordered] Error 2

[astefanutti]

@haydenbleasel thanks for the head up.

[vitallium]

Check list:

• Windows
• Linux
• OS X

[wision]

@astefanutti Thanks for this feature. Could this be configurable per render please?

[JordanMajd]

@vitallium Was able to build and run on Ubuntu Server 14.04 LTS

@astefanutti +1. This is a lifesaver. I want to buy you lunch - do you have a bitcoin account?

[astefanutti]

@wision not trivial, what would be the need to deactivate rendering of hyperlinks as clickable links?

@JordanMajd thanks, you can back https://www.bountysource.com/issues/303463-suggestion-include-hyperlink-action-in-pdf-output-for-hyperlinks-in-webpage 😃.

[wision]

@astefanutti We generate multiple types of documents. Some are generated from our internal network, which means that all the links refer to internal host and that is unwanted. The idea of having to keep two versions of phantomjs binaries (one with and one without hyperlinks) is not ideal either.

[anko]

Do hyperlinks to fragment identifiers like—

See the [table of contents](#toc).

—compile to PDF links to the appropriate section of the same document?

[astefanutti]

Given the externalisation of Qt Base and Qt WebKit as submodules, that PR is superseded by the two following PRs:

• Add support for drawing a hyperlink in QPdfEngine vitallium/qtbase#1
• Render anchors as clickable links in PDF documents vitallium/qtwebkit#1

[saveriodesign]

@astefanutti I'm trying to run the binary you posted through markdown-pdf running from the standard Windows 10 x64 command prompt. It locks down my command prompt without doing anything, no CPU/Memory/Disk activity, and I'm forced to exit the prompt and restart it.

The .exe that comes from npm can be opened directly on my machine while the posted binary, again, simply locks up the windows explorer window from which it's opened while seemingly doing nothing.

[astefanutti]

@miso440 the binary I uploaded has been compiled and tested on Windows 7 x64. Unfortunately I don't have a Windows 10 box to test and troubleshoot. Would you have by chance an older Windows version?

[saveriodesign]

Thank you for the quick response, @astefanutti.

I just took a swing at running it in Window 7 compatibility mode. Same issue both from my script and directly double-clicking. Unfortunately my old Windows 7 disk is DRM'd out of any further installations. Going to see if I can make any magic happen on my Ubuntu 15.04 file server or my Windows 8.1 laptop.

[astefanutti]

@miso440 if you have a reproducible scenario to share that I can test on my platforms, I'll give it a try.

[saveriodesign]

@astefanutti, I got it to work in Windows 8.1 and ran into the issue I was hoping it would fix. I'll detail it in an issue on your page, where's it's more appropriate. Thank you.

[saveriodesign]

@astefanutti I've put together a compressed folder you can download here. It contains my node_modules environment (including 4 PhantomJS binaries) system information, and couple NodeJS scripts which run from the command line.

I greatly appreciate any insight you can give me on the issue I'm experiencing. Thank you.

[kamalbennani]

Can anyone please build a binary file for ubuntu