Refactor driver directory structure #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sksat
added
enhancement
sksat
force-pushed
the
feature/fix-drivers-dir
branch
from
0676030
to
116117b
Compare
sksat
force-pushed
the
feature/fix-drivers-dir
branch
from
116117b
to
931cb3f
Compare
|
@meltingrabbit Driver 周りの改修，まずはここからやりたいです |
user/drivers と core/drivers を両方この１PRでやるということ？ userの変更PRは別，という今までの流れだということならOK． |
|
example user に対する変更は #124 です |
|
OK |
というdocsもちょっと修正してほしい |
|
まあ，別のPRでやるか |
|
Docs\Driver\overview.md |
|
Docs\Tips\parameter_settings.md |
|
OKそう |
meltingrabbit
approved these changes
Oct 12, 2023
This was referenced Oct 13, 2023
This was referenced Oct 23, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
C2A core/user の
Driversディレクトリの構造をリファクタするIssue
詳細
src_core/Drivers/Protocolとsrc_core/Drivers/Superが分割されている意味が無いので，一つのディレクトリにまとめる: 歪なディレクトリ構造を修正する #28 (comment)src_core/DriversにはDriverの実装は存在していないため，複数形なのはおかしい検証結果
#124 で CI が通ればよし
影響範囲
c2a-core/Drivers内のディレクトリ分割がなくなるsrc_core/Drivers,src_user/Driversがsrc_core/driver,src_user/driverになる