Space Packet 関連ファイルのディレクトリを変更 #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meltingrabbit
force-pushed
the
feature/move_space_packet_dir
branch
2 times, most recently
from
a9ed812
to
9ad81bd
Compare
meltingrabbit
force-pushed
the
feature/move_space_packet_dir
branch
from
9ad81bd
to
768d31e
Compare
meltingrabbit
changed the title
sksat
reviewed
Nov 30, 2023
Comment on lines
+29
to
+32
| - `#include <src_core/tlm_cmd/ccsds/space_packet.h>` -> `#include <src_core/tlm_cmd/ccsds/space_packet_protocol/space_packet.h>` | ||
| - `#include <src_core/tlm_cmd/ccsds/space_packet_typedef.h>` -> `#include <src_core/tlm_cmd/ccsds/space_packet_protocol/space_packet_typedef.h>` | ||
| - `#include <src_core/tlm_cmd/ccsds/tlm_space_packet.h>` -> `#include <src_core/tlm_cmd/ccsds/space_packet_protocol/tlm_space_packet.h>` | ||
| - `#include <src_core/tlm_cmd/ccsds/cmd_space_packet.h>` -> `#include <src_core/tlm_cmd/ccsds/space_packet_protocol/cmd_space_packet.h>` |
There was a problem hiding this comment.
ここまで明らかなら migration script 提供してもよいのではないか
sksat
approved these changes
Nov 30, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
Space Packet 関連ファイルのディレクトリを変更
Issue
詳細
検証結果
CI が通ればOK
影響範囲
user 側の include path の修正が必要