Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bash completion #417

Closed
wants to merge 10 commits into from
Closed

bash completion #417

wants to merge 10 commits into from

Conversation

borine
Copy link
Collaborator

@borine borine commented Feb 13, 2021

A bash completion script for the bluez-alsa programs. This makes bluealsa-cli and bluealsa-rfcomm in particular much easier to use as it saves having to type out object paths.

I also found a couple of typos in the man pages while working n this, so there is also a commit for that too.

@arkq
Copy link
Owner

arkq commented Feb 15, 2021

Nice!

When I was testing CLI from your previous PR, I was thinking "it would be really nice to have completion for this tool, at least for D-Bus paths" :D And you've actually made it!

PS.
I've already applied doc fixes.

@borine
Copy link
Collaborator Author

borine commented Feb 16, 2021

This script is not quite perfect - ALSA device names can contain spaces, and this expansion on bluealsa-aplay --pcm= fails with such names. It is on my to-do list to fix that, but may be some time before I get round to it.

Copy link
Owner

@arkq arkq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's hard for me to review it properly, because I'm not a wizard-level basher... I hope you will understand that :D

configure.ac Outdated Show resolved Hide resolved
configure.ac Outdated Show resolved Hide resolved
utils/Makefile.am Show resolved Hide resolved
utils/bash-completion/bluealsa Outdated Show resolved Hide resolved
utils/bash-completion/bluealsa Show resolved Hide resolved
utils/bash-completion/bluealsa Show resolved Hide resolved
configure.ac Outdated Show resolved Hide resolved
utils/Makefile.am Outdated Show resolved Hide resolved
configure.ac Outdated Show resolved Hide resolved
Co-authored-by: Arkadiusz Bokowy <arkadiusz.bokowy@gmail.com>
@arkq arkq closed this in cbe95ae Feb 20, 2021
@arkq
Copy link
Owner

arkq commented Feb 20, 2021

While merging into master, I've changed script location from utils/... to misc/... - this bash completion script is not a util per se. And the misc directory might be a good place for other miscellaneous things - maybe systemd scripts... but I'm not sure about that yet :)

@borine borine deleted the completion branch April 11, 2021 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants