-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GLV parameters structure, v2 #644
Conversation
Co-authored-by: Pratyush Mishra <pratyushmishra@berkeley.edu>
Co-authored-by: Pratyush Mishra <pratyushmishra@berkeley.edu>
Co-authored-by: Pratyush Mishra <pratyushmishra@berkeley.edu>
Co-authored-by: Pratyush Mishra <pratyushmishra@berkeley.edu>
fn endomorphism(p: &Projective<Self>) -> Projective<Self>; | ||
|
||
fn endomorphism_affine(p: &Affine<Self>) -> Affine<Self>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be worth it to add endomorphism(_affine)_in_place
methods to avoid having to create a copy in implementations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it needs at least one copy anyway:
algebra/ec/src/scalar_mul/glv.rs
Line 82 in 83b4d6c
let mut b1 = p; |
@mmagician thank you for the PR! I have left some comments. |
Co-authored-by: Pratyush Mishra <pratyushmishra@berkeley.edu>
7bbf2e2
to
ff4299f
Compare
Co-authored-by: Pratyush Mishra <pratyushmishra@berkeley.edu> Co-authored-by: Simon Masson <simon.masson@yahoo.fr>
This reverts commit ff55cfc.
Description
Building on the work from #588 and introducing slight interface & implementation improvements:
[(bool, Self::ScalarField); 4]
instead of separate structs for bools and scalars. (Best would be to use[(bool, num_bigint::BigInt); 4]
butconst
initialization isn't supported forBigInt
.num_bigint::BigInt
instead ofBigUint
- this way we don't need to keep track of all the signs explicitly.Benches:
closes: #588
@simonmasson
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Pending
section inCHANGELOG.md
Files changed
in the GitHub PR explorer