Skip to content
This repository has been archived by the owner on Dec 18, 2023. It is now read-only.

Fix Bls12-377 scalar group generator #60

Merged
merged 2 commits into from
May 6, 2021

Conversation

alex-ozdemir
Copy link
Contributor

@alex-ozdemir alex-ozdemir commented May 6, 2021

Previously we used 11 as a generator, which has order (p-1)/35.

Now we use 22, which has the right order.

Fixed the two-adic root of unity in accordance with the new generator.

fixes #57


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (master)
  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

Previously we used 11 as a generator, which has order (p-1)/35.

Now we use 22, which has the right order.

Fixed the two-adic root of unity in accordance with the new generator.

fixes arkworks-rs#47
@alex-ozdemir
Copy link
Contributor Author

I guess that tests would have to go in the test template crate.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bls12-377 scalar field "generator" has wrong order
2 participants