Skip to content
This repository has been archived by the owner on Dec 18, 2023. It is now read-only.

adding SW parameters for Bandersnatch curve #67

Merged
merged 18 commits into from
Oct 20, 2021
Merged

adding SW parameters for Bandersnatch curve #67

merged 18 commits into from
Oct 20, 2021

Conversation

zhenfeizhang
Copy link
Contributor

Description

This PR adds the SW parameters for the bandersnatch curve.
see the discussion here: #64 (comment)
(note that this PR does not enable GLV)

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (master)
  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@zhenfeizhang
Copy link
Contributor Author

I guess we should rename EdwardsParameters to BandersnatchParameters?

A related question: should we still name this curve/crate ed_on_bls12_381_bandersnatch or something else?

@zhenfeizhang
Copy link
Contributor Author

The last commitment c576430 adds the SW parameters and related tests for Jubjub curve.

@zhenfeizhang
Copy link
Contributor Author

Hi @Pratyush did you have a chance to review this PR?

@Pratyush
Copy link
Member

This mostly looks good to me, modulo the rustfmt::skip changes, and the information comments.

@zhenfeizhang
Copy link
Contributor Author

zhenfeizhang commented Oct 19, 2021 •
edited
Loading

addressed comments on both SW information and formatter. Also fixed nightly CI.

zhenfeizhang and others added 5 commits October 19, 2021 13:40
@zhenfeizhang @Pratyush
Update ed_on_bls12_381_bandersnatch/src/curves/mod.rs
6921208 
Co-authored-by: Pratyush Mishra <pratyushmishra@berkeley.edu>
@zhenfeizhang @Pratyush
Update ed_on_bls12_381/src/curves/mod.rs
0c1398d 
Co-authored-by: Pratyush Mishra <pratyushmishra@berkeley.edu>
@zhenfeizhang @Pratyush
Update ed_on_bls12_381_bandersnatch/src/constraints/curves.rs
f198a26 
Co-authored-by: Pratyush Mishra <pratyushmishra@berkeley.edu>
@zhenfeizhang
fmt
9f2b88e
@zhenfeizhang
name alias for bandersnatch params
c55c989
@Pratyush Pratyush changed the title adding SW parameters for Bandersnatch curve adding SW parameters for Bandersnatch curve Oct 20, 2021
@Pratyush Pratyush merged commit 461e419 into arkworks-rs:master Oct 20, 2021
@Pratyush Pratyush mentioned this pull request Oct 21, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Pratyush Pratyush Pratyush approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhenfeizhang @Pratyush