Initial rc support #40
Conversation
|
Hi Alex, I'm not against the idea, but why add a new configuration file? while we could add a new option to the current one (option that would default to disabled). |
|
This file is more of a per repo configuration file, i.e. disable tmux-gitbar for certain repos. |
|
It makes sense. I'm ok with that, but i would prefer to have it called |
|
Yep I can so that, but that change only makes sense if there are no future plans to support other repo specific stuff like: GIT_PROMPT_FETCH_REMOTE_STATUS=0, and GIT_PROMPT_SHOW_UNTRACKED_FILES=no (taken from bash-git-prompt). So I could name as above and then just check that the file exists and ignore its contents or I could name the file something like |
|
If one wants to ignore a repo, one won't need other conf options for this repo, so i guess checking for the existence of |
|
Maybe |
|
Could go straight with Also is tmgb meant to update when changing pane, as it does not do that for me! |
|
Checking the existence of a file is straightforward, overall if one wants to have its repo ignored. Don't forget Prior to tmux 2.3, there was no way to know if the user switches pane, so the git bar updates to the repository corresponding to the current pane only after having pressed enter. I opened an issue about that: taking advantage of tmux 2.3 hook feature in order to update immediately when switching panes. At this point it's a bit of a major update because there won't be no more the need to install a $PROMPT_COMMAND. About tmgb placement, there is only left or right for now. I feel like the status bar would be look bloated if we were mixing other information along with it, but that's just personal taste. But you can place tmux keywords inside the tmux status string |
|
Ah right so that would require two implementations and a check for tmux version then, I assume? Yeah, I can't think of an easy way to do it but I use tmuxline.vim and would ideally like it on the right but not as the rightmost element. Not a major problem though. |
Individual repos can now be ignored by placing the file .tmgbignore within the intended repo.
|
Yes indeed. |
|
Before merging, I'd like to add about the new feature in the README, and add some basic tests. If you can do either of both, or both, that would be great. :D If not, I'll do it but I don't know when since i'm a bit overloaded currently. |
|
Yeah I should be able to do that. Where do you want the feature in the README? and I assume I can append the tests into an already existing file? |
|
That's just perfect! Good job! |
|
No worries, had to make up for my botched last PR :) |
|
Ha ha... I've seen way worse ;-) Le 23 nov. 2016 22:51, "Alex Kornitzer" notifications@github.com a écrit :
|
|
What does the ignore actually do? I've put it in a large repo because it was causing me issues (taking several seconds to print the prompt because update_gitbar was running). When I put .tmgbignore in the directory, the status on my tmux bar goes away, but I still see update_gitbar taking several seconds before the prompt is printed. Thanks. |
|
Hi
Thanks for reporting!
`.tmgbignore` obviously should not do that, it should early exit as soon as
possible, just after clearing tmux git status.
Out of curiosity, how large is your repo?
Could you post the output of:
`time git status --porcelain -uall`
If possible with and without tmux git bar.
To disable, unexport PROMPT_COMMAND in a shell.
…On Wed, 20 Jun 2018, 03:09 rbuckley, ***@***.***> wrote:
What does the ignore actually do? I've put it in a large repo because it
was causing me issues (taking several seconds to print the prompt because
update_gitbar was running).
When I put .tmgbignore in the directory, the status on my tmux bar goes
away, but I still see update_gitbar taking several seconds before the
prompt is printed.
Thanks.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#40 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAdF6sP4SmXJlW83S6deIm379AEfcD9Pks5t-aDdgaJpZM4K6wvs>
.
|
|
Hi, thanks for the quick response. It is a large Android repo, about 28GB. time outputs: After unexporting PROMPT_COMMAND |
This is basically a clone of functionality available in bash-git-prompt.
ATM it only supports the ability to ignore repos in the same way as the
aforementioned project.
The above kind of covers it, haven't updated the README incase you reject the changes or wish to change aspects of this. Have only
portedthe ignore feature as I use it. It currently supports TMUX_GITBAR_IGNORE and stores it in .tmux-gitbar-rc