Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add emmc variants to FIT image #4521

Merged
merged 1 commit into from
Dec 7, 2022
Merged

Conversation

ManoftheSea
Copy link
Contributor

Description

Add the emmc DTBs to the FIT image

How Has This Been Tested?

Don't have emmc hardware, but it's very similar to the v5 and v7

Checklist:

@igorpecovnik
Copy link
Member

igorpecovnik commented Dec 5, 2022

This is very hard to test as we don't have HW and before we find someone can take awhile ... but I assume we are not breaking anything if this is merged?

@chips023
Copy link

chips023 commented Dec 6, 2022

This is very hard to test as we don't have HW and before we find someone can take awhile ... but I assume we are not breaking anything if this is merged?

I raised this question on the forum. I can test it as a tester. I have V7 hardware with 4g emmc version
https://forum.armbian.com/topic/24745-espressobin-cant-detect-emmc/

@chips023
Copy link

chips023 commented Dec 7, 2022

This is very hard to test as we don't have HW and before we find someone can take awhile ... but I assume we are not breaking anything if this is merged?

please....please....

@ManoftheSea
Copy link
Contributor Author

@igorpecovnik In case the FIT image fails to build, u-boot will fall back to attempting the boot.scr method. Adding these FDTs to the FIT will not harm existing builds.

@igorpecovnik igorpecovnik merged commit e0dbc8d into armbian:master Dec 7, 2022
@chips023
Copy link

chips023 commented Dec 8, 2022

Love you, great builders~
I can assist in the test at any time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants