Allow to pass docker login when in CI, but not in GitHub actions

[adeepn]

Description

Allow to use Docker credentials for oras-cli push artifacts when CI=true is set, but not in GitHub action.

TODO: fix GITHUB_OUTPUT use if CI=true is set.

Jira reference number AR-2357

How Has This Been Tested?

• correct push to external container registry with CI=true

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• My changes generate no new warnings

[ColorfulRhino]

Could you explain the reasoning behind this to make it easier to understand? Thanks!

[rpardini]

I'll take a guess: I've conflated CI=true with "is under Github Actions".
CI=true I think was classically introduced by Jenkins if memory doesn't fail me

[adeepn]

I'll take a guess: I've conflated CI=true with "is under Github Actions". CI=true I think was classically introduced by Jenkins if memory doesn't fail me

Jenkins, GitLab, hand-run if needed etc

[adeepn]

Could you explain the reasoning behind this to make it easier to understand? Thanks!

When building, we can store artifacts in the registry. However, if the build occurs within a Docker container, we must authenticate before invoking oras-cli. The line at

build/lib/functions/host/docker.sh

Line 476 in 839c5cf

DOCKER_ARGS+=("--mount" "type=bind,source=${docker_config_file_host},target=${docker_config_file_docker}")

transfers Docker authentication information into the build container.

It might be necessary to modify the condition if CI==true to if UPLOAD_TO_OCI_ONLY==yes to better reflect the intended functionality.

[ColorfulRhino]

I see, thanks for your explanation!

[igorpecovnik]

Even this is more or less internal switch, lets add it to the documentation.

[ColorfulRhino]

Even this is more or less internal switch, lets add it to the documentation.

Good idea.

I think work in progress still applies? Since:

TODO: fix GITHUB_OUTPUT use if CI=true is set.

[adeepn]

Seems found more lines to fix...

[igorpecovnik]

Few lines to describe what this switch do https://github.com/armbian/documentation/blob/master/docs/Developer-Guide_Build-Options.md
and I have no more objections. I assume it doesn't break default GH functionality?

[adeepn]

Few lines to describe what this switch do https://github.com/armbian/documentation/blob/master/docs/Developer-Guide_Build-Options.md and I have no more objections.

armbian/documentation#440

I assume it doesn't break default GH functionality?

No. Should not affect to github actions

[ColorfulRhino]

armbian/documentation#440

Well done 👍