-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bootscript: Remove deprecated bootarg "swapaccount=1" #6705
bootscript: Remove deprecated bootarg "swapaccount=1" #6705
Conversation
The "swapaccount=" option has been deprecated in 6.1. Disable it in almost all boot scripts except "boot-sun50iw9.cmd" since that one is used in sun50iw9 legacy kernel, which is version 4.9. Link to kernel commit: torvalds/linux@b25806d
I think we can slowly start to deprecate 5.10.y on Rockchip. Regarding parameters lets wait few days if someone recalls / comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jethub ok.
Yes, I agree 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Yes! The bummer here is that we can't do it conditionally. But let's go ahead, if troubles pop up we adapt as it goes |
Alright so we could remove Do you know anything about Maybe these options are something that are not actually for the linux kernel but for another software? |
Description
The "swapaccount=" option has been deprecated in 6.1. Disable it in almost all boot scripts except "boot-sun50iw9.cmd" since that one is used in sun50iw9 legacy kernel, which is version 4.9.
In theory, rk3588-legacy is also still <6.1, but that boot script is also used by 6.1
vendor
kernel and the amount of new images being built/used with the 5.10 legacy kernel is likely minimal. As far as I know, bootscript won't update automatically, so these changes will only apply to freshly built images. Please correct me if I'm wrong.Link to kernel commit:
torvalds/linux@b25806d
Closes issue #6633
Also, there are other kernel parameters, e.g.:
cgroup_enable=cpuset
cgroup_memory=1
cgroup_enable=memory
build/config/bootscripts/boot-rockchip64.cmd
Line 42 in d7db1cd
I couln't find out why
cgroup_enable=
is added here. The official kernel parameters doc (https://github.com/torvalds/linux/blob/master/Documentation/admin-guide/kernel-parameters.txt) only lists acgroup_disable=
option.Maybe this is some relic of the past? Does anyone know?`
Is there a way to find out on a live kernel what the boot arguments actually did?
Jira reference number AR-2321