cli: uboot: Include PYTHONPATH in env for compiling U-Boot #6819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
size/small
|
I can confirm that this fixes the issue that #6818 tries to solve in another way, since I have just stumbled over the issue on another branch (without this fix applied). After applying the fix from this PR, everything works. Tested compiling U-Boot for NanoPi R5C. |
- Also group all u-boot make environment variables together for easier maintainability - Fixes u-boot requiring `pyelftools` - Fixes commit armbian@04f619d
rpardini
force-pushed
the
uboot-python-env
branch
from
9fea677
to
fb8cb80
Compare
rpardini
approved these changes
Jun 30, 2024
2 tasks
rpardini
reviewed
Jul 17, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
pyelftoolsGitHub issue reference: #6799 (comment)
How Has This Been Tested?
sudo apt remove python3-pyelftoolsand then./compile.sh uboot ARTIFACT_IGNORE_CACHE=yes BOARD=nanopi-r6c BRANCH=edge BUILD_DESKTOP=no BUILD_MINIMAL=no EXPERT=yes KERNEL_CONFIGURE=no RELEASE=trixie./compile.sh uboot ARTIFACT_IGNORE_CACHE=yes BOARD=radxa-zero3 BRANCH=edge BUILD_DESKTOP=no BUILD_MINIMAL=no EXPERT=yes KERNEL_CONFIGURE=no RELEASE=trixieChecklist: