Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Radxa Zero 3(E) - Add mainline/edge support #6824

Closed
wants to merge 10 commits into from
Closed

Conversation

EvilOlaf
Copy link
Member

@EvilOlaf EvilOlaf commented Jun 29, 2024

Description

This adds mainline support for the Radxa Zero 3 SBC by utilizing kwiboo's patch series for both Linux and U-Boot.

How Has This Been Tested?

Test device: Zero 3E 2GB

Issues:

This PR cannot be merged as it is since I have no idea what I am doing so
- the kernel patchset lacks proper headers. I had to strip those since the framework did not accept the patch series as they were. I don't know how to fix. Those need to be restored to give proper credit. Source: https://patchwork.kernel.org/project/linux-arm-kernel/cover/20240521202810.1225636-1-jonas@kwiboo.se/
- this only works for the 3E variant but not for 3W since the vendor variant is a combination of both but mainline provides separate dtbs. This needs attention/workaround as well.

  • BOOTPATCHDIR is just fake so no patches are applied on top of upstream sources. I assume there is a more pretty way to solve this.

Raising anyways to create awareness and maybe anyone wants to pick it up and fix things. Feel free to commit adjustments here and bring it in good shape.

@github-actions github-actions bot added size/large PR with 250 lines or more Hardware Hardware related like kernel, U-Boot, ... Patches Patches related to kernel, U-Boot, ... labels Jun 29, 2024
@Kwiboo
Copy link
Contributor

Kwiboo commented Jun 29, 2024

There has been minor fixes and improvement merged for the upstream device tree of 3e/3w, suggest you pick latest version from linux-rockchip maintainer tree at https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git/log/?h=for-next
Changes include mmc alias change and addition of gpio line names.

@EvilOlaf
Copy link
Member Author

Alright, I adopted the most recent fixes as suggested and added unset. Works on 3E. Cannot test on 3W due to lack of hw on hand.

@rpardini rpardini force-pushed the main branch 2 times, most recently from 7474a69 to 4d036ad Compare June 30, 2024 08:08
@igorpecovnik igorpecovnik added the Work in progress Unfinished / work in progress label Jun 30, 2024
@rpardini
Copy link
Member

doing a slight rework into bare dt patches and some squashing. will push to your branch...

@EvilOlaf
Copy link
Member Author

thx. Building a last image right now to test if this actually (still) works and then would make it ready for review.

@rpardini
Copy link
Member

Using bare dt would remove the "credit", as bare DTs don't have the patch headers at all.
It does save us from patching Makefile, which is always a source of conflicts.
Is that ok?

@EvilOlaf
Copy link
Member Author

Since this is not my work I cannot answer this question. Don't know about the opinion of affected people like Jonas...

@rpardini
Copy link
Member

I'll push to a separate PR for appreciation. Commit still has your name & Co-Authored-by's.

@rpardini
Copy link
Member

rpardini commented Jun 30, 2024

#6842 - that also has an unset BOOTFS_TYPE for mainline, since single-ext4 is fine with mainline u-boot.

@EvilOlaf
Copy link
Member Author

built using this pr works: https://paste.armbian.com/kixewirani
since you picked it up I'll close this one

@EvilOlaf EvilOlaf closed this Jun 30, 2024
@rpardini
Copy link
Member

Ok. was not my intention to hijack the PR; I could've forced-pushed that commit to your branch here.

@EvilOlaf
Copy link
Member Author

its alright, lets not over-complicate things :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hardware Hardware related like kernel, U-Boot, ... Patches Patches related to kernel, U-Boot, ... size/large PR with 250 lines or more Work in progress Unfinished / work in progress
Development

Successfully merging this pull request may close these issues.

4 participants