Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cleanup] Clean leftovers in packages/extras-buildpkgs #6830

Merged
merged 3 commits into from
Jun 30, 2024

Conversation

ColorfulRhino
Copy link
Collaborator

Description

packages/extras-buildpkgs was a leftover from years ago and is not used in the build framework anymore. See #6820 (comment)

With it, remove some references for hostapd and htop. The htop customization in the firstrun script is incompatible with the new versions and throws errors in the firstrun service (see the systemd status of this service after it ran).

GitHub issue reference: #6820

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

@ColorfulRhino ColorfulRhino requested a review from a team as a code owner June 29, 2024 11:27
@github-actions github-actions bot added size/large PR with 250 lines or more Framework Framework components Documentation Documentation changes or additions BSP Board Support Packages labels Jun 29, 2024
The extra package `hostapd` is not used/installed anymore.
They don't work on current versions of `htop`.
@igorpecovnik igorpecovnik added Ready to merge Reviewed, tested and ready for merge 08 Milestone: Third quarter release labels Jun 30, 2024
Copy link
Member

@igorpecovnik igorpecovnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all is obsolete, thank you.

@ColorfulRhino ColorfulRhino merged commit 35f1909 into armbian:main Jun 30, 2024
9 checks passed
@ColorfulRhino ColorfulRhino deleted the extra-packages-cleanup branch July 2, 2024 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
08 Milestone: Third quarter release BSP Board Support Packages Documentation Documentation changes or additions Framework Framework components Ready to merge Reviewed, tested and ready for merge size/large PR with 250 lines or more
Development

Successfully merging this pull request may close these issues.

3 participants