Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bsp: armbian-install: fix the search for eMMC and SD card devices #7017

Merged
merged 2 commits into from
Aug 4, 2024
Merged

bsp: armbian-install: fix the search for eMMC and SD card devices #7017

merged 2 commits into from
Aug 4, 2024

Conversation

The-going
Copy link
Contributor

@The-going The-going commented Aug 2, 2024 •
edited
Loading

Description

On different boards, eMMC and SDcard memory devices can have numbers 0, 1, 2 in any sequence.
SDcard -> 0; eMMC -> 2
SDcard -> 1; eMMC -> 0
SDcard -> 0; eMMC -> 1

eMMC has additional physical partitions such as *boot0, *boot1 and others.
Use this attribute for unambiguous identification.

Print the type and name of the memory device in the message to the user.

GitHub issue on #6958

How Has This Been Tested?

  • Test work on board

@The-going
bsp: armbian-install: fix the search for eMMC and SD card devices
41560ec 
On different boards, eMMC and SDcard memory devices can have
numbers 0, 1, 2 in any sequence.
SDcard -> 0; eMMC -> 2
SDcard -> 2; eMMC -> 0
SDcard -> 0; eMMC -> 1

eMMC has additional physical partitions such as *boot0,
*boot1 and others.
Use this attribute for unambiguous identification.

Print the type and name of the memory device in the message
to the user.
@The-going The-going requested a review from a team as a code owner August 2, 2024 08:58
@github-actions github-actions bot added size/small PR with less then 50 lines BSP Board Support Packages labels Aug 2, 2024
@The-going
Copy link
Contributor Author

@liwei19920307 Please take a look.
Will this work correctly for you?

@igorpecovnik igorpecovnik added 08 Milestone: Third quarter release Needs review Seeking for review labels Aug 3, 2024
@liwei19920307
Copy link

@liwei19920307 Please take a look. Will this work correctly for you?

Sorry, it's late, I tested the latest script and everything looks like it's working fine

1 2 3

@igorpecovnik
Copy link
Member

FYI. When Android is preinstalled on eMMC

image

it fails with "partition too small".

Running script again, succeeded. eMMC shows correctly.

@igorpecovnik
Copy link
Member

Also eMMC boot / NVME install. It does eMMC install correctly ... but not nvme. If i start armbian-install again (when running from eMMC) and choose nvme install, this time it moves to nvme. (tested on Nanopi R6C)

@The-going
Copy link
Contributor Author

... but not nvme.

Please provide details.
The point of choice? downloading from a SD card?

@igorpecovnik
Copy link
Member

Yes, boot from SD card on device that has eMMC and NVME present.

@The-going
Copy link
Contributor Author

Yes, boot from SD card on device that has eMMC and NVME present.

And try to install the boot from eMMC and the root partition on NVME (3)
or (1) boot from SD, root on NVME.

Okay, I get it.
I have all the devices for this.
This will require a thorough logic check and will take time. Let me do it after sunxi-edge.
Let's merge it, because it fixes a bug that I mistakenly assumed that the SD card always has
the number 0 in the device name.

@liwei19920307 Thanks for the very detailed feedback.

@igorpecovnik
Copy link
Member

Let me do it after sunxi-edge.

Agree.

@igorpecovnik igorpecovnik added Ready to merge Reviewed, tested and ready for merge and removed Needs review Seeking for review labels Aug 4, 2024
@igorpecovnik igorpecovnik added the Bugfix Pull request is fixing a bug label Aug 4, 2024
@igorpecovnik igorpecovnik merged commit 8797b23 into armbian:main Aug 4, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igorpecovnik igorpecovnik igorpecovnik approved these changes

Assignees
No one assigned
Labels
08 Milestone: Third quarter release BSP Board Support Packages Bugfix Pull request is fixing a bug Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@The-going @liwei19920307 @igorpecovnik