Missing ‘lexical-binding’

[finn-matti]

Total emacs newbie here.

I am using emacs 31.1 with spacemacs and the php layer and I get this error:

Warning (files): Missing ‘lexical-binding’ cookie in "~/.emacs.d/elpa/31.1/develop/drupal-mode-20240816.1236/drupal/flycheck.el".

According to this issue in the spacemacs repo, this might be fixed by adding lexical-binding: nil to the files. It seems like it does when I patch my local file. But I am unsure enough to open a q&a thread instead of an issue.

[hippi345]

your patch is the right fix, and it's only a warning. newer emacs complains when it loads an .el file without the cookie, then loads it with the old dynamic binding anyway, so drupal-mode behaves exactly the same either way. lexical-binding: nil is the safe value since that's what the file was written for.

downside is the patch gets wiped every time the package updates, and drupal-mode hasn't had a commit since aug 2024. if you'd rather just hide it, the warning type is (files missing-lexbind-cookie ...), so in dotspacemacs/user-config:

(with-eval-after-load 'warnings
  (add-to-list 'warning-suppress-types '(files missing-lexbind-cookie)))

that hides it for every package missing the cookie, not just this one. opening an issue here asking for the cookie in the drupal/*.el files would be the proper long term fix.

[xendk]

Well, drupal-mode is getting a bit long in the tooth, and has been overtaken by changes in both Emacs and Drupal, so it's kinda minimally maintained. But if someone creates a working pull request, I'd say that there's a good chance it'll get merged and a patch release tagged.