Fix LAPACK definitions #2239
Merged
Fix LAPACK definitions #2239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9prady9
reviewed
Jul 16, 2018
| @@ -508,7 +505,8 @@ if(LAPACK_FOUND) | |||
| dependency_check(CBLAS_LIBRARIES "CBLAS not found.") | |||
| target_include_directories(afopencl | |||
| PRIVATE | |||
| ${CBLAS_INCLUDE_DIR}) | |||
| ${CBLAS_INCLUDE_DIR} | |||
| ${LAPACK_INCLUDE_DIR}) | |||
| target_link_libraries(afopencl | |||
| PRIVATE | |||
| ${CBLAS_LIBRARIES} | |||
There was a problem hiding this comment.
cpu cmake file adds LAPACK_LIBRARIES. Isn't it needed here as well ?
There was a problem hiding this comment.
nvm, I couldn't see the line after CBLAS_LIBRARIES in the diff.
| @@ -32,6 +32,8 @@ target_sources(afcommon_interface | |||
| ${CMAKE_CURRENT_SOURCE_DIR}/err_common.hpp | |||
| ${CMAKE_CURRENT_SOURCE_DIR}/host_memory.cpp | |||
| ${CMAKE_CURRENT_SOURCE_DIR}/host_memory.hpp | |||
| ${CMAKE_CURRENT_SOURCE_DIR}/lapacke.cpp | |||
| ${CMAKE_CURRENT_SOURCE_DIR}/lapacke.hpp | |||
There was a problem hiding this comment.
If LAPACK libs or MKL was not found, then wouldn't this cause an issue ? We can build without linear algebra support earlier, wouldn't this break that ?
There was a problem hiding this comment.
Those files have ifdefs for apple/OSX. Accelerate framework is always installed on that system. On Linux and windows we don't need those files but the hpp file is included in a couple of places.
9prady9
approved these changes
Jul 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets WITH_LINEAR_ALGEBRA if MKL is found