svdInPlace: Flip the inequality on the dims restriction #2331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umar456
previously approved these changes
Oct 30, 2018
| svdInPlaceTest<TypeParam>(500, 300); | ||
| } | ||
|
|
||
| // dim0 < dim1 case not supported for now |
There was a problem hiding this comment.
An expect throw/error would be a better test but this is fine.
|
@mark-poscablo |
umar456
approved these changes
Nov 19, 2018
9prady9
pushed a commit
to 9prady9/arrayfire
that referenced
this pull request
Mar 27, 2019
* Remove dims restriction from svdInPlace * Restore dims assertion, but flipped the direction of the inequality. Updated docs. (cherry picked from commit 2c6b5c0)
umar456
pushed a commit
that referenced
this pull request
Apr 17, 2019
* Remove dims restriction from svdInPlace * Restore dims assertion, but flipped the direction of the inequality. Updated docs. (cherry picked from commit 2c6b5c0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on #2282,
svdInPlacedid have its inequality on the input array dims restriction flipped. It asserted before that the input'sdim0 <= dim1, but I flipped it to>=, which is what it should've been (see the issue for my explanation of why this should be the case). I addded some tests to verify this and I also noted this down in the docs for future users of this function.