Remove cudaMemcpys to the default streams in the CUDA backend #2362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were some calls being made to the default CUDA stream. This is problematic because the default cuda stream is blocks and blocks all other streams when executing. We should only perform calls on the current stream.
syurkevi
approved these changes
Nov 30, 2018
|
Cool. Could we expect any significant speedup ? |
|
I don't think there would be a speedup in your application here. We are still synchronizing after the call to cudaMemcpy because its interacting with user code. If you were using other kernels in your application you could see a small speedup then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some calls being made to the default CUDA stream. This is
problematic because the default cuda stream is blocks and blocks
all other streams when executing. We should only perform calls on
the current stream.