-
Notifications
You must be signed in to change notification settings - Fork 547
Log dynamic lib loading failures from unified API #2670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Failure output with
|
Success
|
WilliamTambellini
previously approved these changes
Nov 12, 2019
umar456
requested changes
Nov 12, 2019
umar456
approved these changes
Nov 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Help resolves #2634
Added
AF_TRACE
commands when load library fails. Until now, only success is being reported in trace logs.Cleaned up a unnecessary redirection in symbol_manage.cpp.
I tried to put trace command in
UNIFIED_ERROR_LOAD_LIB
macro but the dlerror call by that point is returning NULL because of earlier reads. I am still trying to figure out why/where this is happening.