Skip to content

Move matrixmarket downloads to build stage #2742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 7, 2020

Conversation

9prady9
Copy link
Member

@9prady9 9prady9 commented Feb 6, 2020

No description provided.

@9prady9 9prady9 requested a review from umar456 February 6, 2020 07:05
endfunction()

# Following files are used for testing mtx read fn
# integer data
download_mtx("Trec4" "JGD_Kocay")
mtxDownload("Trec4" "JGD_Kocay")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you use the original file names directly instead of putting it in a "group"? That way there will be less obfuscation.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The grouping is not introduced in our code. The mtx files are organized in that manner: files under different groups can have identical names. The tar file download URL also follows the same convention.

@umar456 umar456 merged commit 930cbdc into arrayfire:master Feb 7, 2020
@9prady9 9prady9 deleted the improv_mtx_exp branch February 10, 2020 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants