Fetch dependencies and data using CMake FetchContent #3037
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9prady9
force-pushed
the
fetch_content_deps
branch
5 times, most recently
from
eec54b6 to
c80a7a9
Compare
9prady9
force-pushed
the
fetch_content_deps
branch
from
c80a7a9 to
ed6a324
Compare
9prady9
force-pushed
the
fetch_content_deps
branch
2 times, most recently
from
7dade42 to
00407d7
Compare
9prady9
force-pushed
the
fetch_content_deps
branch
from
00407d7 to
078865f
Compare
9prady9
force-pushed
the
fetch_content_deps
branch
3 times, most recently
from
d1140c9 to
9107788
Compare
9prady9
force-pushed
the
fetch_content_deps
branch
from
72822f8 to
31580dc
Compare
9prady9
force-pushed
the
fetch_content_deps
branch
from
9107788 to
b82c62f
Compare
Removed assets and test/data as submodules
- spdlog - cub - threads
When the above cmake option is turned ON, via the below command ```cmake ccmake .. -DAF_BUILD_OFFLINE:BOOL=ON ``` FetchContent will look for dependencies under build tree's extern folder and will not attempt to download any of them. By default this option is turned OFF
- cl2.hpp header download - clBLAS build - clFFT build - CLBlast build Use clBLAS and clFFT via add_subdir instead of external project
9prady9
force-pushed
the
fetch_content_deps
branch
from
b82c62f to
4e06d7b
Compare
umar456
approved these changes
Feb 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed all the following submodules to be fetched via CMake's FetchContent command. Unfortunately, this command is made available only in 3.11.4, thus we copied the required files to our repository's
CMakeModulesfolder.Also, marked cmake variables with FETCHCONTENT prefix as advanced
Changes to Users
None to downstream users. Repository cloning and starting the build process is expected to become slightly easier.
Checklist
[ ] Functions added to unified API[ ] Functions documented