Use boost's epsilon difference when comparing floating point values #3212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umar456
force-pushed
the
half_test_fix
branch
5 times, most recently
from
61177aa to
e2ff3e4
Compare
This commit changes the way we compare floating point values in the tests to use the boost math's epsilon difference to compare two floating point values for equality. This is a more accurate form of equality and handles differences in half float values when the values reach a certain threshold.
umar456
force-pushed
the
half_test_fix
branch
from
e2ff3e4 to
f290e0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use epsilon difference to compare floating point values in tests
Description
This commit changes the way we compare floating point values in the
tests to use the boost math's epsilon difference to compare two floating
point values for equality. This is a more accurate form of equality and
handles differences in half float values when the values reach a
certain threshold.
Changes to Users
N/A
Checklist
[ ] Functions added to unified API[ ] Functions documented