Skip to content

Conversation

bdraco
Copy link
Contributor

@bdraco bdraco commented May 5, 2020

Add constants that are currently living in
Home Assistant and should be in this package.

Fixes #34

Add constants that are currently living in
Home Assistant and should be in this package.
@dseven
Copy link
Contributor

dseven commented May 5, 2020

Applied the patch in my home assistant container. It works!

@FlyingDiver
Copy link

Could you briefly describe the exact changes you needed to make in the requests to the MyQ servers? I'm having a hard time telling from the code changes what you actually needed to do.

I have a different (not Home Assistant) setup that is (loosely) based on this code. So I need to migrate your 5.1 changes to my setup.

@FlyingDiver
Copy link

Oh, wait, I think I see. You need to use ".../api/v5/..." for the authentication and account info calls, but ".../api/v5.1/..." for the device specific calls.

@jcollas
Copy link

jcollas commented May 5, 2020

The patch works fine for me. Much appreciated.

@broyuken
Copy link

broyuken commented May 6, 2020

This didn't work for me. I had removed the MyQ integration to see if that caused the issue, now when I click on it to re-add it, it just goes back to the list of integrations instead of giving me the login prompt to finish configuring it.

@bdraco
Copy link
Contributor Author

bdraco commented May 6, 2020

@ehendrix23 Sorry to bother, it looks like you've been doing the merges.

@broyuken
Copy link

broyuken commented May 6, 2020

I just replaced those 3 files in my container, anything else I need to do to get this working?

@kongeng
Copy link

kongeng commented May 6, 2020

yes, replaced the 3 files in the container and restart. I had to remove and add the myq integration back because i had changed my password.

@broyuken
Copy link

broyuken commented May 6, 2020

Yea that doesn’t work for me, it just kicks me back to the list of integrations.

edit, I did a dumb. copy/paste error in vi. It's working great now, thank you!

@KosmixLB
Copy link

KosmixLB commented May 6, 2020

It's working me as well. Thanks so much!!

@untergeek
Copy link

Oh, thank you. Please merge and publish this to PyPi. I'd rather do a pip install -U than manually patch files.

@bperkins011
Copy link

Copied the 3 files, restarted, works for me too. Thanks!

@garyak
Copy link

garyak commented May 6, 2020

Copied the api.py, const.py, and device.py file and replaced existing files. Restarted, but still unavailable.

@tjuel
Copy link

tjuel commented May 6, 2020

As a HA noob, can you help describe how I can get to the api through the home assistant frontend? Or do I have to access via CLI? I'm not a programmer so apologies in advance.

@dasb00ter
Copy link

dasb00ter commented May 6, 2020

As a HA noob, can you help describe how I can get to the api through the home assistant frontend? Or do I have to access via CLI? I'm not a programmer so apologies in advance.

Well as a non noob I thought you could just drop these https://github.com/bdraco/pymyq.git a custom components folder and away you go but I get an unexpected error when I login and the log is not warning me that I'm using a custom component for myq so I guess I'm not doing it right?

@dseven
Copy link
Contributor

dseven commented May 6, 2020

I don't mean to be rude, but perhaps those who are not familiar with applying patches could just wait until the fix is released, then update your HA systems as you normally would? If you actually know what you're doing, and believe that the proposed fix is insufficient, those reports may be valuable here.

@garyak
Copy link

garyak commented May 6, 2020

Yes, I'll just wait until the next release. I have other options for actuating my garage doors.

@dasb00ter
Copy link

I don't mean to be rude, but perhaps those who are not familiar with applying patches could just wait until the fix is released, then update your HA systems as you normally would? If you actually know what you're doing, and believe that the proposed fix is insufficient, those reports may be valuable here.

I dont think your rude. Your right in that github is a place to troubleshoot and develop. Still the nature of the community that I have experienced is to help, especially if I can help back. Help me to help you so to speak.Well typically patching these files directly is not to my understanding the best practice. I've done the above procedure numerous times to get a good result. I certainly make mistakes though. I get the login prompt and get an error. I'll leave that as feedback for people who know more than me. I certainly wont be replying anymore since I agree chatter to a minimum

@kyotodesertfox
Copy link

kyotodesertfox commented May 6, 2020

It's possible that your experiencing some sort of authentication issue on MyQ end.

The reason that I suggest this is I received the exact same error when I completely removed the integration and tried to re-add it thinking it was something on my end before learning the issue was resolved via an API update.

But it might not be anything that you're doing, necessarily.

@dale3h
Copy link

dale3h commented May 6, 2020

I was able to temporarily apply the patch in Hass.io using the following steps:

  1. Login to SSH via Community SSH & Web Terminal add-on.
  2. Execute command docker exec -it homeassistant /bin/bash
  3. Once inside the homeassistant Docker container, execute command pip install -e git://github.com/bdraco/pymyq.git@v51_update#egg=pymyq
  4. Restart Home Assistant.

This tells pip to install directly from the v51_update branch of @bdraco's pymyq fork. The files should be automatically be overwritten the next time Home Assistant is updated.

@nikiyao
Copy link

nikiyao commented May 6, 2020

@dale3h I can't seem to get this to work I keep getting

bash: docker: command not found

@dale3h
Copy link

dale3h commented May 6, 2020

@nikiyao Which version of the Community SSH & Web Terminal add-on do you have installed on your Hass.io system?

@nikiyao
Copy link

nikiyao commented May 6, 2020

@dale3h 8.5.4

@dale3h
Copy link

dale3h commented May 6, 2020

@nikiyao That's the Official SSH & Terminal add-on. The patching process I described above requires the Community SSH & Web Terminal add-on, which can be installed from the Add-on Store on your Supervisor panel, under the Home Assistant Community Add-ons section.

@nikiyao
Copy link

nikiyao commented May 6, 2020

Oh ok thanks

@rct
Copy link

rct commented May 6, 2020

@nikiyao last I checked you also need to disable "protected mode" in order to have access to docker. Note: you'll get some big red warnings when you disable protected mode.

@kyotodesertfox
Copy link

I used Portainer and was able to skip the Community SSH portion entirely.

I performed the steps suggested by @dale3h; works like a charm!

@nikiyao
Copy link

nikiyao commented May 6, 2020

@dale3h that worked great thank you

@dale3h
Copy link

dale3h commented May 6, 2020

@txwindsurfer I am not sure that the login command applies when using the Community SSH & Web Terminal add-on. In my experience, you only have to type the login command when connecting directly to the root filesystem of HassOS.

@txwindsurfer
Copy link

You are correct, removed my post

@msauto
Copy link

msauto commented May 6, 2020

Confirmed fix dale3h , thanks so much for taking the time to let every one know!!!

@itzalgd24
Copy link

I used Portainer as well, back up and running here. Thanks @dale3h !

@codydaig
Copy link

codydaig commented May 7, 2020

Patch tested on Python 3.6 and works great.

@csriebel08
Copy link

Thanks! Confirmed worked for me as well. Thanks for the hard work!

@dasb00ter
Copy link

Fix included in 0.109.6 thanks a bunch bdraco

@tkdk1cks
Copy link

tkdk1cks commented Jun 6, 2020

STill cant get this to work.

@dasb00ter
Copy link

STill cant get this to work.

Probably changed there api again was working for me with this fix now down again in the last couple of days

@txwindsurfer
Copy link

Fixed in latest release:

https://github.com/home-assistant/core/releases/tag/0.110.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suddenly JSONDecodeError