-
Notifications
You must be signed in to change notification settings - Fork 38
Update for api v5.1 #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add constants that are currently living in Home Assistant and should be in this package.
Applied the patch in my home assistant container. It works! |
Could you briefly describe the exact changes you needed to make in the requests to the MyQ servers? I'm having a hard time telling from the code changes what you actually needed to do. I have a different (not Home Assistant) setup that is (loosely) based on this code. So I need to migrate your 5.1 changes to my setup. |
Oh, wait, I think I see. You need to use ".../api/v5/..." for the authentication and account info calls, but ".../api/v5.1/..." for the device specific calls. |
The patch works fine for me. Much appreciated. |
This didn't work for me. I had removed the MyQ integration to see if that caused the issue, now when I click on it to re-add it, it just goes back to the list of integrations instead of giving me the login prompt to finish configuring it. |
@ehendrix23 Sorry to bother, it looks like you've been doing the merges. |
I just replaced those 3 files in my container, anything else I need to do to get this working? |
yes, replaced the 3 files in the container and restart. I had to remove and add the myq integration back because i had changed my password. |
Yea that doesn’t work for me, it just kicks me back to the list of integrations. edit, I did a dumb. copy/paste error in vi. It's working great now, thank you! |
It's working me as well. Thanks so much!! |
Oh, thank you. Please merge and publish this to PyPi. I'd rather do a |
Copied the 3 files, restarted, works for me too. Thanks! |
Copied the api.py, const.py, and device.py file and replaced existing files. Restarted, but still unavailable. |
As a HA noob, can you help describe how I can get to the api through the home assistant frontend? Or do I have to access via CLI? I'm not a programmer so apologies in advance. |
Well as a non noob I thought you could just drop these https://github.com/bdraco/pymyq.git a custom components folder and away you go but I get an unexpected error when I login and the log is not warning me that I'm using a custom component for myq so I guess I'm not doing it right? |
I don't mean to be rude, but perhaps those who are not familiar with applying patches could just wait until the fix is released, then update your HA systems as you normally would? If you actually know what you're doing, and believe that the proposed fix is insufficient, those reports may be valuable here. |
Yes, I'll just wait until the next release. I have other options for actuating my garage doors. |
I dont think your rude. Your right in that github is a place to troubleshoot and develop. Still the nature of the community that I have experienced is to help, especially if I can help back. Help me to help you so to speak.Well typically patching these files directly is not to my understanding the best practice. I've done the above procedure numerous times to get a good result. I certainly make mistakes though. I get the login prompt and get an error. I'll leave that as feedback for people who know more than me. I certainly wont be replying anymore since I agree chatter to a minimum |
It's possible that your experiencing some sort of authentication issue on MyQ end. The reason that I suggest this is I received the exact same error when I completely removed the integration and tried to re-add it thinking it was something on my end before learning the issue was resolved via an API update. But it might not be anything that you're doing, necessarily. |
I was able to temporarily apply the patch in Hass.io using the following steps:
This tells |
@dale3h I can't seem to get this to work I keep getting
|
@nikiyao Which version of the Community SSH & Web Terminal add-on do you have installed on your Hass.io system? |
@dale3h 8.5.4 |
@nikiyao That's the Official SSH & Terminal add-on. The patching process I described above requires the Community SSH & Web Terminal add-on, which can be installed from the Add-on Store on your Supervisor panel, under the Home Assistant Community Add-ons section. |
Oh ok thanks |
@nikiyao last I checked you also need to disable "protected mode" in order to have access to docker. Note: you'll get some big red warnings when you disable protected mode. |
I used Portainer and was able to skip the Community SSH portion entirely. I performed the steps suggested by @dale3h; works like a charm! |
@dale3h that worked great thank you |
@txwindsurfer I am not sure that the |
You are correct, removed my post |
Confirmed fix dale3h , thanks so much for taking the time to let every one know!!! |
I used Portainer as well, back up and running here. Thanks @dale3h ! |
Patch tested on Python 3.6 and works great. |
Thanks! Confirmed worked for me as well. Thanks for the hard work! |
Fix included in 0.109.6 thanks a bunch bdraco |
STill cant get this to work. |
Probably changed there api again was working for me with this fix now down again in the last couple of days |
Fixed in latest release: |
Add constants that are currently living in
Home Assistant and should be in this package.
Fixes #34