-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Episode 11 #72
Episode 11 #72
Conversation
@ming13 please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few small additions
11. Validate resulting RSS feed, for example w/ [this tool](http://castfeedvalidator.com) | ||
10. Update README: add new Episode information | ||
11. Post a PR with show notes and RSS feed update. | ||
12. Validate resulting RSS feed, for example w/ [this tool](http://castfeedvalidator.com) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
show_notes/Episode_11.md
Outdated
- [RxJava 2: Discussion about null values](https://github.com/ReactiveX/RxJava/issues/4644#issuecomment-256684743) | ||
- [Reactive Streams specification: null value](https://github.com/reactive-streams/reactive-streams-jvm/issues/204) | ||
- [Why RxJava 3: Split the library into two or adding types for symmetry](https://github.com/ReactiveX/RxJava/issues/4564) | ||
- [RxJava 3 Preview](https://github.com/akarnokd/RxJava3-preview) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[RxJava 2 Kotlin SAM issue combineLatest()/etc](https://github.com/ReactiveX/RxKotlin/issues/103)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added!
- Artem Zinnatullin [@artem_zin](https://twitter.com/artem_zin), [personal blog](http://artemzin.com), [GitHub](https://github.com/artem-zinnatullin) | ||
|
||
#### Additional links: | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Juno's Android Rider Team RxJava 2 Migration Specification](https://github.com/gojuno/engineering/blob/master/specs/rxjava-2-migration.md)
It should be there at the time of publishing the episode, for now it's in the PR gojuno/engineering#1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
feed.rss
Outdated
<li>Flowable or Observable?</li> | ||
<li>Other Rx Types: Single, Maybe and Completable</li> | ||
<li>RxJava 2 interop library</li> | ||
<li>RxJava 2: Default UncaughtExceptionHandler logs exceptions silently in jvm unit tests</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick — JVM
- Flowable or Observable? | ||
- Other Rx Types: Single, Maybe and Completable | ||
- RxJava 2 interop library | ||
- RxJava 2: Default UncaughtExceptionHandler logs exceptions silently in jvm unit tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick — JVM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch. Changed.
|
||
#### Guest: | ||
|
||
- Artur Dryomov [GitHub](https://github.com/ming13) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need your twitter handle, @ming13, it's a blocker!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uhh
@artem-zinnatullin I have listened to latest Fragmented Podcast episode to compare the volume level with our episode. Fragmented is a little bit louder. Probably we should increase the volume of the whole file by 3-4 db. Unfortunately, I haven't audition on my machine at work. So if you do have audition installed and have 2 minutes of free time because of gradle build 😄 it would be great if you could increase the volume of the whole mp3 file by 3-4 db. Otherwise, I will do it this evening at home. |
The major issue with the sound is not the overall sound level. It just becomes uncomfortable to listen to the show when the sound level of different speakers is different a lot - which is natural just by the fact how far you are away from the microphone, how loud you speak or which microphone you use. This becomes tedious when you listening to podcast on the street, in the train, ... what many people, that I know, do. No, I do not work for Auphonic :) I just learned about them in this podcast episode. |
Thanks @johnjohndoe for your feedback. And here is the automatically edited file by Auphonic: Auphonic applied the average volume level, but the problem is that at the end of the episode our guest @ming13 was more away from the microphone then at the beginning and that some words of sentences were recorded poorly. With automatically avg. volume adjustment like Auphonic did it sounds much worse from my point of view. If you have time to listen at 40:00 - 50:00 of both files we will take your feedback into account. |
Sorry for the microphone issue guys. Really was trying to be steady and at the same place ;-( |
No problem: 95% of the audio is fine. Also quality of content is more
important then audio volume imho.
I just wanted to make a point that we might have to make some compromises
while editing which may mean lower audio volume (or not averaged volume
level) since we were not recording this in a perfect environment like a
studio nor we have the knowledge and time to edit each second of the
episode perfectly.
However, if such automated tools exist like Auphonic and do a better job
than we do, then of course we would just use them. However, imho Auphonic
didn't work that well if the recorded files are already not perfect (which
is almost always true for our podcast since we can't expect our guests to
have professional microphones). Nevertheless, we are thankful for every
feedback and suggestions. If someone knows a strong AI for audio editing,
please let us know :)
Artur Dryomov <notifications@github.com> schrieb am Di., 16. Mai 2017,
10:26:
… Sorry for the microphone issue guys. Really was trying to be steady and at
the same place ;-(
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#72 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAjnrvxhYW1t3g5wneSZc0-UpOJleGNzks5r6V3MgaJpZM4NbPZX>
.
|
I listened to and compared both files. I definitely prefer
I disagree with you on this point. I imagine you loose a lot of listeners. When it is inconvenient to listen to the recording it is regardless how interesting the content might be. Just to get more opinions: You might want to directly ask your listeners in the next show by running a survey or similar. |
ATP is my favourite podcast and there is a brief (and probably mostly outdated) explanation on how the podcast is made. Obviously Marco knows a lot about podcasts, he even created an app, so all editing mumbo-jumbo is on his side. Cannot find his story on the editing though. |
Thanks for your feedback @johnjohndoe . Then @artem-zinnatullin we should ship this file: @artem-zinnatullin don't forget to rename it to @ming13 the main difference is hardware I guess. Actually I think hardware matters the most. For example, my microphone is a semi professional (120$), Artem's one is about 65 $. For example in Episode 8 Damn functional programming Paco used a headset with microphone, mabe 30 $. We can't expect guests to have a semi professional microphone That was one reason why in Episode 10: Kotlin Language Design Nitpicking, Dmitry Jemerov used my microphone to record his voice and my voice was a little bit less clear / volume was a little bit low. The equipment of ATP podcast equipment:
So more than 1000$ in hardware and that is the major difference. Also they have a desk and fixed place to record the episode so that the distance between mic and his mouth is almost the same through the whole episode (which was the issue during this recording): I think the major impact on sound quality is hardware. However, editing could improve the quality too. Since this is a very time consuming progress, we will try out a mix of both automated audio processing tools like Auphonic and manually audio editing for the next episodes. If it turns out that automated audio processing works quite good, I would be more than happy to spent some bucks on such services. Thanks for your feedback and help! |
@sockeqwe I have to agree with @johnjohndoe point and Android Developers Backstage example, lemme mix both of your opinions: Sound quality should be good enough, however of course content quality is what we are aiming for. I also like Auphonic version better, pricing of the service seems okay, @sockeqwe let's try to publish this version and ask users about results so we could decide whether we should process new episodes with this service or not? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sockeqwe thank you for hard work on releasing this episode! I hope from now we'll just need to combine tracks in one and process it through Auphonic and it'll take much less time! |
feed.rss
Outdated
@@ -779,7 +779,7 @@ | |||
<atom:link rel="replies" type="text/html" href="https://github.com/artem-zinnatullin/TheContext-Podcast/issues/71"/> | |||
<itunes:duration>52:46</itunes:duration> | |||
<pubDate>Mon, 15 May 2017 09:30:00 EST</pubDate> | |||
<enclosure url="https://artemzin.com/static/thecontext/episodes/The.Context.episode.11.mp3" length="50684128" type="audio/mpeg"/> | |||
<enclosure url="https://artemzin.com/static/thecontext/episodes/The.Context.episode.11.mp3" length="50658006" type="audio/mpeg"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exceptional good catch! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was very surprised that auto editing almost did not change file size, mp3 indeed is a very interesting format
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because I used the already manually pre edited files for this episode. Auto editing results weren't that good with raw recorded mp3 files (much background noises and breathing after auto editing). So I think Auphonic was mostly adjusting volume and might have improved some pieces here and there.
Well, not sure about it ... Tried Auphonic with other tracks episode ... Audition did a much better job on removing background noises and dynamic processing for removing echo and makes recorded voice clearer and bolder at the same time. Also our multitracks have different length depending on the record.
However, somethings (and those are the time consuming things) are still to be done manually (maybe after automatically processing):
To be honest, I would like to not do that time consuming things at all (especially removing breathing) because we are not a professional podcast nor we earn any money in comparison for the time we put into producing the podcast. But this (time consuming) things are the important ones that make a good sound quality. It is mainly a hardware (microphone) issue of our guests. Auphonic didn't remove any of these things (breathing, clicking etc. at least with my test files) automatically. And those are the time consuming things while editing / processing a podcast. Imho, we can't get rid of manually editing unless everybody has some good hardware (microphone). Btw. Autphonic suggests to export the mp3 file with 112 kBit/s which reduces the size of mp3 file for a few MB #70 Thanks everybody for your feedback and help. Really appreciated it. |
@sockeqwe plan SGTM! |
Feed is valid: http://castfeedvalidator.com/?url=https://raw.githubusercontent.com/artem-zinnatullin/TheContext-Podcast/episode11/feed.rss
mp3 file url must be: https://artemzin.com/static/thecontext/episodes/The.Context.episode.11.mp3
TODO: