Skip to content

ISO6346 - Bug fix for the case when the checksum is 10 #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

ISO6346 - Bug fix for the case when the checksum is 10 #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion stdnum/iso6346.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ def validate(number):
raise InvalidLength()
if not _iso6346_re.match(number):
raise InvalidFormat()
if calc_check_digit(number[:-1]) != number[-1]:
if calc_check_digit(number[:-1])[-1:] != number[-1]:
raise InvalidChecksum()
return number

Expand Down
2 changes: 2 additions & 0 deletions tests/test_iso6346.doctest
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,8 @@ True
'TCNU7200794'
>>> iso6346.validate('tolu4734787')
'TOLU4734787'
>>> iso6346.validate('GYOU4047990')
'GYOU4047990'


Test with invalid numbers:
Expand Down