Skip to content

Conversation

vbastos
Copy link

@vbastos vbastos commented Sep 19, 2016

Hey - Just thought I would add some Australian numbers to your module.

@arthurdejong
Copy link
Owner

Thanks for your contribution. There are a few minor bugs in your code but those are easily fixed.

Could you provide some small bit of text for each module's docstring? Perhaps with a pointer to more information.

Also do you know of any public registry or source of valid numbers of each type? For these kind of numbers I generally run tests against a large collection of found numbers and include a few in the test suite to try to avoid bugs (e.g. some numbers are documented to have a checksum but a significant percentage of real numbers fail the checksum test).

Thanks!

@vbastos
Copy link
Author

vbastos commented Sep 20, 2016

Sorry about the bugs.

I'll update the branch with text for each module's docstring. I'll have a look at what I can get for you, but as far as I understand it there should not be any exceptions to the checksum.

Link for valid ACN's - http://asic.gov.au/for-business/starting-a-company/how-to-start-a-company/australian-company-numbers/australian-company-number-digit-check/

Links with information or validator -
ABN - https://abr.business.gov.au/HelpAbnFormat.aspx
TFN - https://www.anao.gov.au/sites/g/files/net616/f/anao_report_1998-99_37.pdf

@arthurdejong
Copy link
Owner

I have made some modifications to your code and added some tests in 70b94ee, 8028c3a and 8ea76ba.

Thanks for providing your patch.

arthurdejong added a commit that referenced this pull request Oct 14, 2016
Based on the implementation provided by Vincent Bastos
<vincent@lavalab.com.au>

See #40
arthurdejong added a commit that referenced this pull request Oct 14, 2016
Based on the implementation provided by Vincent Bastos
<vincent@lavalab.com.au>

See #40
arthurdejong added a commit that referenced this pull request Oct 14, 2016
Based on the implementation provided by Vincent Bastos
<vincent@lavalab.com.au>

See #40
@vbastos
Copy link
Author

vbastos commented Nov 26, 2016

Ah sorry Arthur! Thanks for closing that one off.

xmo-odoo added a commit to odoo-dev/odoo that referenced this pull request Jul 30, 2024
Although support for Australian ABN was added in stdnum
1.5 (arthurdejong/python-stdnum#40) it was in a bespoke module, which
only got aliased to VAT in 1.15 (arthurdejong/python-stdnum#246),
therefore a shim was necessary to bridge the two.

Since Odoo now requirements stdnum 1.17, it should not be necessary
anymore.
robodoo pushed a commit to odoo/odoo that referenced this pull request Aug 1, 2024
Although support for Australian ABN was added in stdnum
1.5 (arthurdejong/python-stdnum#40) it was in a bespoke module, which
only got aliased to VAT in 1.15 (arthurdejong/python-stdnum#246),
therefore a shim was necessary to bridge the two.

Since Odoo now requirements stdnum 1.17, it should not be necessary
anymore.

Part-of: #175008
Signed-off-by: Wala Gauthier (gawa) <gawa@odoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants