Add clearOnSameDateClick prop (Issue #24) #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically deployed with Now. |
Codecov Report
@@ Coverage Diff @@
## master #25 +/- ##
=========================================
- Coverage 9.75% 9.68% -0.07%
=========================================
Files 13 13
Lines 287 289 +2
Branches 58 59 +1
=========================================
Hits 28 28
- Misses 206 207 +1
- Partials 53 54 +1
Continue to review full report at Codecov.
|
|
@jalavosus, great work! Thanks for adding this feature. Can you rebase your branch and solve the conflict so I can merge it? And feel free to add yourself to the contributors table by running the |
This prop, if `false`, will prevent the component's state from resetting if the same date is clicked in succession. So as to not break previous or expected default behavior, the default value of this prop is `true`.
being equal to `false`.
arthurdenner
pushed a commit
that referenced
this pull request
Feb 25, 2019
* Add clearOnSameDateSelect prop to basic datepicker. This prop, if `false`, will prevent the component's state from resetting if the same date is clicked in succession. So as to not break previous or expected default behavior, the default value of this prop is `true`. * Add storybook entry for the clearOnSameDateClick prop being equal to `false`. * Updated README.md to reflect clearOnSameDateClick prop.
arthurdenner
pushed a commit
that referenced
this pull request
Feb 25, 2019
* Add clearOnSameDateSelect prop to basic datepicker. This prop, if `false`, will prevent the component's state from resetting if the same date is clicked in succession. So as to not break previous or expected default behavior, the default value of this prop is `true`. * Add storybook entry for the clearOnSameDateClick prop being equal to `false`. * Updated README.md to reflect clearOnSameDateClick prop.
|
The features in your PRs are now published in the version 1.9.0. 🎉 Thanks once again, @jalavosus! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This PR is a first draft implementation of my proposal in #24.
It introduces a new prop,
clearOnSameDateClick(bool), which controls whether or not the state of the datepicker component gets reset if the same date is clicked in succession.Ex. I click the "Today" button, and then click it again.
With the default behavior (prop=
true), the entire datepicker would reset (including clearing the previous selection).If
clearOnSameDateClickis set tofalse, the datepicker doesn't reset, and the previous selection is maintained with each successive click of the same date.Checklist:
yarn testpasses)Closes #24.